Skip to content

Commit 4ac91f6

Browse files
committed
opentelemetry: use static strings for event targets
This changes the `tracing-opentelemetry` subscriber to use `&'static str`s for event targets when possible, similarly to how we did this for source locations in #1911. Signed-off-by: Eliza Weisman <[email protected]>
1 parent 2db3750 commit 4ac91f6

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

tracing-opentelemetry/src/subscriber.rs

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -554,13 +554,23 @@ where
554554
let meta = normalized_meta.as_ref().unwrap_or_else(|| event.metadata());
555555
#[cfg(not(feature = "tracing-log"))]
556556
let meta = event.metadata();
557+
558+
let target = Key::new("target");
559+
560+
#[cfg(feature = "tracing-log")]
561+
let target = if normalized_meta.is_some() {
562+
target.string(meta.target().to_owned())
563+
} else {
564+
target.string(event.metadata().target())
565+
};
566+
567+
#[cfg(not(feature = "tracing-log"))]
568+
let target = target.string(meta.target());
569+
557570
let mut otel_event = otel::Event::new(
558571
String::new(),
559572
SystemTime::now(),
560-
vec![
561-
Key::new("level").string(meta.level().to_string()),
562-
Key::new("target").string(meta.target().to_string()),
563-
],
573+
vec![Key::new("level").string(meta.level().to_string()), target],
564574
0,
565575
);
566576
event.record(&mut SpanEventVisitor(&mut otel_event));

0 commit comments

Comments
 (0)