Skip to content

Commit bf28492

Browse files
committed
Refactoring of console request
1 parent a53867f commit bf28492

File tree

1 file changed

+8
-25
lines changed

1 file changed

+8
-25
lines changed

src/Misc/ConsoleRequest.php

+8-25
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,10 @@ public function makeRequest(string $url, string $method, array $values, array $a
2020
{
2121
list($postFields, $getFields, $cookieFields, $rawPost, $putFields) = $this->processValues($values);
2222

23-
if (isset($additionalValues['postFields'])) {
24-
$postFields = array_merge($postFields, $additionalValues['postFields']);
25-
}
26-
27-
if (isset($additionalValues['getFields'])) {
28-
$getFields = array_merge($postFields, $additionalValues['getFields']);
29-
}
30-
31-
if (isset($additionalValues['cookieFields'])) {
32-
$cookieFields = array_merge($postFields, $additionalValues['cookieFields']);
33-
}
34-
35-
if (isset($additionalValues['putFields'])) {
36-
$putFields = array_merge($putFields, $additionalValues['putFields']);
37-
}
23+
$postFields = array_merge($postFields, $additionalValues['postFields'] ?? []);
24+
$getFields = array_merge($getFields, $additionalValues['getFields'] ?? []);
25+
$cookieFields = array_merge($cookieFields, $additionalValues['cookieFields'] ?? []);
26+
$putFields = array_merge($putFields, $additionalValues['putFields'] ?? []);
3827

3928
$postFields = $this->normalizeValues($postFields);
4029
$getFields = $this->normalizeValues($getFields);
@@ -68,18 +57,12 @@ public function makeRequest(string $url, string $method, array $values, array $a
6857
curl_setopt($curl, CURLOPT_VERBOSE, false);
6958
curl_setopt($curl, CURLOPT_TIMEOUT, 10);
7059
curl_setopt($curl, CURLOPT_HEADER, true);
71-
if (count($postFields)) {
72-
curl_setopt($curl, CURLOPT_POST, true);
73-
curl_setopt($curl, CURLOPT_POSTFIELDS, $postFields);
74-
}
75-
if ($rawPost) {
76-
curl_setopt($curl, CURLOPT_POST, true);
77-
curl_setopt($curl, CURLOPT_POSTFIELDS, $rawPost);
78-
}
79-
if ($putRawPost) {
60+
61+
if (count($postFields) || $rawPost || $putRawPost !== null) {
8062
curl_setopt($curl, CURLOPT_POST, true);
81-
curl_setopt($curl, CURLOPT_POSTFIELDS, $putRawPost);
63+
curl_setopt($curl, CURLOPT_POSTFIELDS, count($postFields) ? $postFields : ($rawPost ?: $putRawPost));
8264
}
65+
8366
if (count($cookieFields)) {
8467
$parts = [];
8568
foreach ($cookieFields as $key => $value) {

0 commit comments

Comments
 (0)