Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate SHA1 hashes in the manifest #3

Open
tomasmcguinness opened this issue Nov 20, 2018 · 1 comment
Open

Validate SHA1 hashes in the manifest #3

tomasmcguinness opened this issue Nov 20, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@tomasmcguinness
Copy link
Owner

I had a report from a user struggling to open a pass. Turns out that one of the hashes in the manifest.json file was incorrect. It would be useful to have the validator actually check this.
@tomasmcguinness tomasmcguinness added the enhancement New feature or request label Nov 20, 2018
@fly2high1
Copy link

I altered the file pass.json but the SHA1 hash was not checked and pkpass file is vilidated. This not ok, this not enhancement is it core functionality missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomasmcguinness @fly2high1