Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect comparisons with "stop" string #323

Open
GrosQuildu opened this issue Apr 21, 2023 · 1 comment
Open

Incorrect comparisons with "stop" string #323

GrosQuildu opened this issue Apr 21, 2023 · 1 comment

Comments

@GrosQuildu
Copy link

In two places strncmp is called with invalid size argument - either too large or to small:

if (strncmp(extra, "stop", 3) == 0) {

bStopRx = (strncmp(input, "stop", 5) == 0) ? 1 : 0; /* strncmp TRUE is 0*/

@tomaspinho
Copy link
Owner

Hey! Appreciate the report. Would you be keen on opening a PR with fixes for these? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants