Async plugins (#6)

change context parent (UserDict), add support for fully async plugins and middleware

Author: tomwojcik

README.md

@@ -51,7 +51,7 @@ app.add_middleware(ContextMiddleware.with_plugins(  # easily extensible
 
 @app.route('/')
 async def index(request: Request):
-    return JSONResponse(context.dict())
+    return JSONResponse(context.data)
 
 
 uvicorn.run(app, host="0.0.0.0")

examples/example_with_exception_handling/app.py

@@ -2,7 +2,10 @@
 
 from starlette.applications import Starlette
 from starlette.exceptions import HTTPException
-from starlette.middleware.base import BaseHTTPMiddleware, RequestResponseEndpoint
+from starlette.middleware.base import (
+    BaseHTTPMiddleware,
+    RequestResponseEndpoint,
+)
 from starlette.requests import Request
 from starlette.responses import JSONResponse, Response
 from starlette.status import HTTP_500_INTERNAL_SERVER_ERROR

examples/example_with_exception_handling/logger.py

@@ -23,7 +23,7 @@ def __init__(self, logger, extra=None):
 
     def process(self, msg, kwargs):
         extra = self.extra.copy()
-        extra.update(context.dict())
+        extra.update(context.data)
 
         kwargs["extra"] = extra
         return msg, kwargs

examples/example_with_logger/app.py

@@ -12,7 +12,7 @@
 @app.route("/")
 async def index(request: Request):
     log.info("Log from view")
-    return JSONResponse(context.dict())
+    return JSONResponse(context.data)
 
 
 app.add_middleware(

examples/example_with_logger/logger.py

@@ -24,7 +24,7 @@ def __init__(self, logger, extra=None):
     def process(self, msg, kwargs):
         # here we are basically adding context to log
         extra = self.extra.copy()
-        extra.update(context.dict())
+        extra.update(context.data)
 
         kwargs["extra"] = extra
         return msg, kwargs

examples/simple_examples/set_context_in_middleware.py

@@ -16,7 +16,7 @@
 
 @app.route("/")
 async def index(request: Request):
-    return JSONResponse(context.dict())
+    return JSONResponse(context.data)
 
 
 uvicorn.run(app, host="0.0.0.0")

examples/simple_examples/set_context_in_middleware_and_view.py

@@ -12,11 +12,11 @@
 @app.route("/")
 async def index(request: Request):
     context["view"] = True
-    return JSONResponse(context.dict())
+    return JSONResponse(context.data)
 
 
 class ContextFromMiddleware(ContextMiddleware):
-    def set_context(self, request: Request) -> dict:
+    async def set_context(self, request: Request) -> dict:
         return {"middleware": True}
 
 

examples/simple_examples/set_context_in_view.py

@@ -20,7 +20,7 @@ async def index(request: Request):
         a="b", ts=str(datetime.datetime.utcnow()), uuid=uuid.uuid4().hex
     )
 
-    return JSONResponse(context.dict())
+    return JSONResponse(context.data)
 
 
 uvicorn.run(app, host="0.0.0.0")

pytest.ini

@@ -7,4 +7,5 @@ addopts =
     --doctest-modules
     --cov=skift
     -r a
-    -v
+    -v
+    --strict

requirements-dev.txt

@@ -12,6 +12,7 @@ pytest==5.3.2
 pytest-cov==2.8.1
 pytest-sugar==0.9.2
 pytest-xdist==1.31.0
+pytest-asyncio==0.10.0
 codecov
 
 # lint