Use a different icon compared to the backgrounds addon #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Nice! Thanks for creating the PR this is great. Let's see what the contributors think. cc: @tonai
|
@nickofthyme I'm not very hopeful of the PR being merged (the last activity on the repo was three months ago). If the icon problem is significant for you, I'd recommend using the fork in the meantime. |
|
Yeah I'm hoping that's not the case 🤞🏼. I opened another pr to add the |
|
Good effort @dhruvkb 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50.
This PR changes the icon used by the add-on from
phototomirroras the photo icon is already used by the official, bundled backgrounds add-on.Before:
After:
The mirror icon made personal sense to me as I was using this add-on to manage light and dark themes but there are a lot of other icons in this list to choose from, which is why accepting it as a config option would be awesome.
References: