Skip to content

Commit 10bdad9

Browse files
committed
chore(mypy): docutils linting
src/django_docutils/lib/roles/common.py:134: error: Too many arguments for "Text" [call-arg] src/django_docutils/lib/metadata/extract.py:57: error: Need more than 0 values to unpack (2 expected) [misc] src/django_docutils/lib/publisher.py:36: error: Need type annotation for "reader" [var-annotated] src/django_docutils/lib/publisher.py:48: error: Unused "type: ignore" comment [unused-ignore] src/django_docutils/lib/publisher.py:50: error: Unused "type: ignore" comment [unused-ignore] src/django_docutils/lib/publisher.py:124: error: Returning Any from function declared to return "document" [no-any-return] Found 6 errors in 3 files (checked 55 source files)
1 parent 96158e0 commit 10bdad9

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

src/django_docutils/lib/metadata/extract.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ def extract_metadata(document: nodes.document) -> dict[str, str]:
5454
continue
5555

5656
if element.tagname == "field": # custom fields (e.g. summary)
57+
assert len(element.children) == 2
5758
name_elem, body_elem = element.children
5859
assert isinstance(name_elem, (nodes.Text, nodes.Element))
5960
assert isinstance(body_elem, (nodes.Text, nodes.Element))

src/django_docutils/lib/publisher.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def publish_parts_from_doctree(
3333
enable_exit_status: bool = False,
3434
) -> dict[str, str]:
3535
"""Render docutils doctree into docutils parts."""
36-
reader = Reader(parser_name="null")
36+
reader = Reader(parser_name="null") # type:ignore
3737
pub = Publisher(
3838
reader,
3939
None,
@@ -45,9 +45,9 @@ def publish_parts_from_doctree(
4545
if not writer and writer_name:
4646
pub.set_writer(writer_name)
4747
pub.process_programmatic_settings(
48-
settings_spec, # type:ignore
48+
settings_spec,
4949
settings_overrides,
50-
config_section, # type:ignore
50+
config_section,
5151
)
5252
pub.set_destination(None, destination_path)
5353
pub.publish(enable_exit_status=enable_exit_status)
@@ -121,7 +121,7 @@ def publish_doctree(
121121
register_django_docutils_directives()
122122
register_django_docutils_roles()
123123

124-
return docutils_publish_doctree(
124+
return docutils_publish_doctree( # type:ignore
125125
source=force_bytes(source),
126126
settings_overrides=settings_overrides,
127127
)

src/django_docutils/lib/roles/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def url_handler(target):
130130
if not has_explicit_title:
131131
title = utils.unescape(remote_title)
132132

133-
sn = innernodeclass(title, title)
133+
sn = innernodeclass(title)
134134
rn = nodes.reference("", "", internal=True, refuri=url, classes=[name])
135135
rn += sn
136136
return [rn], []

0 commit comments

Comments
 (0)