Module path should be "github.com/toorop/go-bitcoind", not "github.com/vpashka/go-bitcoind"

[KateGo520]

Background

Module path is inconsistent with go import path.
GO111MODULE=on, as doc said, import "github.com/toorop/go-bitcoind", then get this error:

go: finding module for package github.com/toorop/go-bitcoind
go: downloading github.com/toorop/go-bitcoind v0.0.0-20191125160357-28204734ac83
go: found github.com/toorop/go-bitcoind in github.com/toorop/go-bitcoind v0.0.0-20191125160357-28204734ac83
go: test1 imports
        github.com/toorop/go-bitcoind: github.com/toorop/go-bitcoind@v0.0.0-20191125160357-28204734ac83: parsing go.mod:
        module declares its path as: github.com/vpashka/go-bitcoind
                but was required as: github.com/toorop/go-bitcoind 

Solution

Fix the module path:

1. Rename the module path to "github.com/toorop/go-bitcoind": https://github.com/toorop/go-bitcoind/blob/master/go.mod#L1

module github.com/toorop/go-bitcoind
go 1.12 

2. Warning the users not to use the module, get "github.com/toorop/go-bitcoind" in GOPATH mode.

[KateGo520]

@vpashka Could you help me review this issue? Thx :p

[vpashka]

Yes.
There is a fix here
https://github.com/toorop/go-bitcoind/pull/25/files

[KateGo520]

@vpashka Thanks for your efforts and feedback.