Update authentication flow #881
Description
Problem
Currently, the web arena uses custom code for validating the tcsso cookie:
There's also code here that uses it:
https://github.com/appirio-tech/arena-web/blob/9d1b51c62b5619688baefe71b93ec0a45229524b/app/js/resolvers.js#L137
https://github.com/appirio-tech/arena-web/blob/9d1b51c62b5619688baefe71b93ec0a45229524b/app/js/factories.js#L1068
https://github.com/appirio-tech/arena-web/blob/9d1b51c62b5619688baefe71b93ec0a45229524b/app/js/factories.js#L1071
https://github.com/appirio-tech/arena-web/blob/9d1b51c62b5619688baefe71b93ec0a45229524b/app/js/controllers/baseCtrl.js#L661
The problem is that we no longer want to use the tcsso cookie for the web arena. Instead, we just want to validate that the JWT token is valid, similar to what the community app does, using the TC Core Lib dependency
- Community app: https://github.com/topcoder-platform/community-app
- Core JS dependency: https://github.com/topcoder-platform/community-app/blob/develop/package.json#L154
Solution
Instead of using tcsso manually in the arena web, we want to transition to using the TC Core Lib dependency linked to above, in the web arena.
The TC Core Lib uses the v3 bearer token instead of tcsso, which is more current and easier to manage for Topcoder.
Examples:
- https://github.com/topcoder-platform/community-app/blob/2fc0270bb6d9837b31760863c1ca800b149b84da/src/shared/containers/Settings.jsx#L9
- https://github.com/topcoder-platform/community-app/blob/2fc0270bb6d9837b31760863c1ca800b149b84da/src/shared/containers/Settings.jsx#L47
Caveats
We need to make sure that the arena still can call the APIs appropriately using the updated bearer token. I don't see anywhere where we are using the tcsso token, but there are a couple places where the arena code appears to be using the jwtToken. This should be the same as the v3token, but we'll need to ensure that it still works as expected when we switch to use the TC Core Lib dependency.
For reference:
- https://github.com/appirio-tech/arena-web/blob/9d1b51c62b5619688baefe71b93ec0a45229524b/app/js/factories.js#L1074
- https://github.com/appirio-tech/arena-web/blob/9d1b51c62b5619688baefe71b93ec0a45229524b/app/js/controllers/practiceProblemListCtrl.js#L74
Testing
Testing details will be provided in the F2F challenge forum.