Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

Update Design challenge html template #99

Open
sushilshinde opened this issue Jan 9, 2019 · 11 comments
Open

Update Design challenge html template #99

sushilshinde opened this issue Jan 9, 2019 · 11 comments
Assignees

Comments

@sushilshinde
Copy link
Contributor

sushilshinde commented Jan 9, 2019

Formatting should look like that used to look in v3

V3 template.zip

Currently, in v4 it looks like this which is wrong.

https://www.topcoder.com/challenges/30078581

@sushilshinde
Copy link
Contributor Author

Original issue reported here topcoder-platform/community-app#1860

@sushilshinde
Copy link
Contributor Author

fyi @ajefts @cwdcwd

@skyhit
Copy link
Contributor

skyhit commented Jan 9, 2019

@ajefts @cwdcwd @sushilshinde originally, it is formalized like https://github.com/topcoder-platform/tc-elasticsearch-feeder-service/blob/dev/src/main/java/com/appirio/service/challengefeeder/manager/ChallengeDetailFeederManager.java#L136-L148

which format should we follow? I can make the change. or we should return field separately, and let community app to control the format, but this is conflicting our purpose to have unified detail description field.

@sushilshinde
Copy link
Contributor Author

sushilshinde commented Jan 9, 2019

No, we need to add HTML formatting in the templating. Share the original template.

@skyhit
Copy link
Contributor

skyhit commented Jan 11, 2019

@sushilshinde share the original template? we don't have actually, previously, it is part of the UI work, let's define some?

@sushilshinde
Copy link
Contributor Author

detailedRequirements value is being built by code
https://api.topcoder.com/v4/challenges/30078581

that's what I'm referring to @skyhit

@skyhit
Copy link
Contributor

skyhit commented Jan 11, 2019

@sushilshinde yeah, I mean how to concatenate these pieces.

@skyhit
Copy link
Contributor

skyhit commented Jan 12, 2019

image

@sushilshinde there are some fixed text in the middle, how to handle? see the yellow section

@sushilshinde
Copy link
Contributor Author

By adding a placeholder for the fixed text in their returned HTML

This is dynamic code generated in api

This is dynamic code generated in api

or generate complete HTML on in API only

@skyhit

@sushilshinde
Copy link
Contributor Author

@skyhit this is old template

screenshot 2019-01-24 17-57-51

@sushilshinde
Copy link
Contributor Author

sushilshinde commented May 24, 2019

@skyhit there are still few issues with the fix

  1. Challenge Introduction/Challenge Summary is not being returned as part of introduction field
    http://api.topcoder-dev.com/v4/challenges/30055072
introduction: "<h3 class='roundLabel'>Round 1</h3> <h3 class='roundLabel'>Round 2</h3>",

Comapared to v3

http://api.topcoder-dev.com/v3/challenges/30055072

introduction: "This is challenge introduction",
round1Introduction: "Round 1 info",
round2Introduction: "round 2 info",

It should be returned as

introduction: "<p>This is challenge introduction</p><h3 class='roundLabel'>Round 1</h3> <h3 class='roundLabel'>Round 2</h3>",
  1. It shouldn’t show the Round headings if it’s not a multi-round challenge: https://test-community-app.topcoder-dev.com/challenges/30054531

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants