start with all Sub Communities selected by default

Author: lightmare

Diff for: src/containers/Filter/ChallengeFilter/index.jsx

@@ -225,30 +225,22 @@ const ChallengeFilter = ({
                     const isTCOEvent = utils.challenge.isTCOEventCommunity(
                       subCommunity
                     );
-                    let filterChange;
+                    const filterChange = { events, groups };
 
                     if (isTCOEvent) {
-                      const newEvents = checked
-                        ? events.concat(
-                            utils.challenge.getCommunityEvent(subCommunity)
-                          )
-                        : events.filter(
-                            (event) =>
-                              event !==
-                              utils.challenge.getCommunityEvent(subCommunity)
-                          );
-                      filterChange = { events: newEvents };
+                      const scEvent = utils.challenge.getCommunityEvent(
+                        subCommunity
+                      );
+                      filterChange.events = checked
+                        ? _.union(events, [scEvent])
+                        : _.without(events, scEvent);
                     } else {
-                      const newGroups = checked
-                        ? groups.concat(
-                            utils.challenge.getCommunityGroup(subCommunity)
-                          )
-                        : groups.filter(
-                            (group) =>
-                              group !==
-                              utils.challenge.getCommunityGroup(subCommunity)
-                          );
-                      filterChange = { groups: newGroups };
+                      const scGroup = utils.challenge.getCommunityGroup(
+                        subCommunity
+                      );
+                      filterChange.groups = checked
+                        ? _.union(groups, [scGroup])
+                        : _.without(groups, scGroup);
                     }
 
                     updateFilter(filterChange);

Diff for: src/containers/Filter/index.jsx

@@ -58,6 +58,12 @@ const Filter = ({
         updateQuery(filterChange);
       }}
       updateFilter={(filterChange) => {
+        // turn off community filters if all sub-communities are selected
+        const n = filterChange.groups.length + filterChange.events.length;
+        if (n >= challengeSubCommunities.length) {
+          filterChange.events = [];
+          filterChange.groups = [];
+        }
         updateFilter(filterChange);
         updateQuery(filterChange);
       }}
@@ -90,6 +96,32 @@ Filter.propTypes = {
   updateQuery: PT.func,
 };
 
+function getSelectedCommunityEvents(state) {
+  if (
+    state.filter.challenge.events.length > 0 ||
+    state.filter.challenge.groups.length > 0
+  ) {
+    return state.filter.challenge.events;
+  } else {
+    return state.lookup.subCommunities
+      .filter(utils.challenge.isTCOEventCommunity)
+      .map(utils.challenge.getCommunityEvent);
+  }
+}
+
+function getSelectedCommunityGroups(state) {
+  if (
+    state.filter.challenge.events.length > 0 ||
+    state.filter.challenge.groups.length > 0
+  ) {
+    return state.filter.challenge.groups;
+  } else {
+    return state.lookup.subCommunities
+      .filter(utils.challenge.isGroupCommunity)
+      .map(utils.challenge.getCommunityGroup);
+  }
+}
+
 const mapStateToProps = (state) => ({
   state: state,
   bucket: state.filter.challenge.bucket,
@@ -99,8 +131,8 @@ const mapStateToProps = (state) => ({
   totalPrizesFrom: state.filter.challenge.totalPrizesFrom,
   totalPrizesTo: state.filter.challenge.totalPrizesTo,
   recommended: state.filter.challenge.recommended,
-  events: state.filter.challenge.events,
-  groups: state.filter.challenge.groups,
+  events: getSelectedCommunityEvents(state),
+  groups: getSelectedCommunityGroups(state),
   challengeBuckets: state.lookup.buckets,
   challengeTypes: state.lookup.types,
   challengeTracks: state.lookup.tracks,