Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit 44cf5fc

Browse files
Merge pull request #70 from topcoder-platform/bugbash
Bugbash Fixes
2 parents 5c7a8de + d7de22c commit 44cf5fc

File tree

10 files changed

+20
-18
lines changed

10 files changed

+20
-18
lines changed

.circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ workflows:
7777
branches:
7878
only:
7979
- dev
80-
- challenge-listing-part-2
80+
- bugbash
8181

8282
# Production builds are exectuted only on tagged commits to the
8383
# master branch.

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,5 @@ Make sure you have [Heroky CLI](https://devcenter.heroku.com/articles/heroku-cli
5656

5757
- `git push heroku master` - push changes to Heroku and trigger deploying
5858

59-
- Now you have to configure frame app to use the URL provided by Heroku like `https://<APP-NAME>.herokuapp.com/topcoder-micro-frontends-earn-app.js` to load this microapp.
59+
- Now you have to configure frame app to use the URL provided by Heroku like `https://<APP-NAME>.herokuapp.com/earn-app/topcoder-micro-frontends-earn-app.js` to load this microapp.
6060

config/default.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
module.exports = {
2-
GUIKIT: {
2+
GUIKIT: {
33
DEBOUNCE_ON_CHANGE_TIME: 150,
44
},
55
API: {
66
V5: "https://api.topcoder-dev.com/v5",
77
V3: "https://api.topcoder-dev.com/v3",
88
},
99
URL: {
10+
BASE: "https://www.topcoder-dev.com",
1011
COMMUNITY_APP: "https://community-app.topcoder-dev.com",
11-
}
12-
}
12+
},
13+
};

config/development.js

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ module.exports = {
77
V3: "https://api.topcoder-dev.com/v3",
88
},
99
URL: {
10+
BASE: "https://www.topcoder-dev.com",
1011
COMMUNITY_APP: "https://community-app.topcoder-dev.com",
1112
},
1213
};

config/production.js

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ module.exports = {
77
V3: "https://api.topcoder.com/v3",
88
},
99
URL: {
10+
BASE: "https://www.topcoder.com",
1011
COMMUNITY_APP: "https://community-app.topcoder.com",
1112
},
1213
};

src/constants/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export const FILTER_CHALLENGE_TRACK_ABBREVIATIONS = {
4242
};
4343

4444
export const CHALLENGE_SORT_BY = {
45-
"Best Match": "bestMatch",
45+
// "Best Match": "bestMatch",
4646
"Most recent": "updated",
4747
"Prize amount": "overview.totalPrizes",
4848
Title: "name",

src/containers/Challenges/Listing/ChallengeItem/index.jsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const ChallengeItem = ({ challenge, onClickTag, onClickTrack }) => {
3838
<div styleName="name-container">
3939
<h6 styleName="name">
4040
<a
41-
href={`${process.env.URL.COMMUNITY_APP}/challenges/${challenge.id}`} // eslint-disable-line no-undef
41+
href={`${process.env.URL.BASE}/challenges/${challenge.id}`} // eslint-disable-line no-undef
4242
>
4343
{challenge.name}
4444
</a>
@@ -65,12 +65,12 @@ const ChallengeItem = ({ challenge, onClickTag, onClickTrack }) => {
6565
</div>
6666
<div styleName="nums">
6767
<a
68-
href={`${process.env.URL.COMMUNITY_APP}/challenges/${challenge.id}?tab=registrants`} // eslint-disable-line no-undef
68+
href={`${process.env.URL.BASE}/challenges/${challenge.id}?tab=registrants`} // eslint-disable-line no-undef
6969
>
7070
<NumRegistrants numOfRegistrants={challenge.numOfRegistrants} />
7171
</a>
7272
<a
73-
href={`${process.env.URL.COMMUNITY_APP}/challenges/${challenge.id}?tab=submissions`} // eslint-disable-line no-undef
73+
href={`${process.env.URL.BASE}/challenges/${challenge.id}?tab=submissions`} // eslint-disable-line no-undef
7474
>
7575
<NumSubmissions numOfSubmissions={challenge.numOfSubmissions} />
7676
</a>

src/containers/Challenges/index.jsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { connect } from "react-redux";
44
import Listing from "./Listing";
55
import actions from "../../actions";
66
import ChallengeError from "./Listing/errors/ChallengeError";
7-
import ChallengeRecommendedError from "./Listing/errors/ChallengeRecommendedError";
7+
// import ChallengeRecommendedError from "./Listing/errors/ChallengeRecommendedError";
88
import * as constants from "../../constants";
99
import IconListView from "../../assets/icons/list-view.svg";
1010
import IconCardView from "../../assets/icons/card-view.svg";
@@ -60,7 +60,7 @@ const Challenges = ({
6060
{challenges.length === 0 && initialized && <ChallengeError />}
6161
{challenges.length > 0 && (
6262
<>
63-
{noRecommendedChallenges && <ChallengeRecommendedError />}
63+
{/*noRecommendedChallenges && <ChallengeRecommendedError />*/}
6464
<Listing
6565
challenges={challenges}
6666
search={search}

src/containers/Filter/ChallengeFilter/index.jsx

+5-6
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const ChallengeFilter = ({
3232
updateFilter,
3333
openForRegistrationCount,
3434
}) => {
35-
const BUCKET_OPEN_FOR_REGISTRATION = constants.FILTER_BUCKETS[1];
35+
// const BUCKET_OPEN_FOR_REGISTRATION = constants.FILTER_BUCKETS[1];
3636
const tagOptions = utils.createDropdownTermOptions(challengeTags);
3737
const bucketOptions = utils.createRadioOptions(challengeBuckets, bucket);
3838

@@ -260,8 +260,8 @@ const ChallengeFilter = ({
260260
</div>
261261
</div>
262262
)}
263-
264-
{bucket === BUCKET_OPEN_FOR_REGISTRATION && (
263+
{/* DISABLED UNTIL IMPLEMENT RECOMMENDED CHALLENGES */}
264+
{/* bucket === BUCKET_OPEN_FOR_REGISTRATION && (
265265
<div styleName="recommended-challenges">
266266
<span styleName="toggle">
267267
<Toggle
@@ -278,11 +278,10 @@ const ChallengeFilter = ({
278278
</span>
279279
<span>Recommended Challenges</span>
280280
</div>
281-
)}
282-
281+
)*/}
283282
<div styleName="footer">
284283
<Button onClick={clearFilter}>CLEAR FILTER</Button>
285-
<Button onClick={saveFilter}>SAVE FILTER</Button>
284+
{/*<Button onClick={saveFilter}>SAVE FILTER</Button>*/}
286285
</div>
287286
</div>
288287
);

src/reducers/filter.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const defaultState = {
2222
// ---
2323

2424
bucket: constants.FILTER_BUCKETS[1],
25-
recommended: true,
25+
recommended: false,
2626
},
2727
};
2828

0 commit comments

Comments
 (0)