Skip to content

Commit 1566d0f

Browse files
fix security rules when getting a single challenge
1 parent cd8ba6b commit 1566d0f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/services/ChallengeService.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -946,7 +946,7 @@ async function getChallenge (currentUser, id) {
946946
// Check if challenge is task and apply security rules
947947
if (_.get(challenge, 'task.isTask', false) && _.get(challenge, 'task.isAssigned', false)) {
948948
const skipAccessCheck = !currentUser ? false : currentUser.isMachine || helper.hasAdminRole(currentUser)
949-
if (!skipAccessCheck && currentUser && _.toString(currentUser.userId) !== _.get(challenge, 'task.memberId')) {
949+
if (!skipAccessCheck && currentUser && _.toString(currentUser.userId) !== _.toString(_.get(challenge, 'task.memberId'))) {
950950
throw new errors.ForbiddenError(`You don't have access to view this challenge`)
951951
}
952952
}

0 commit comments

Comments
 (0)