-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sorting by "GET /resources" endpoint #51
Comments
@rootelement but in code it's marked as required: |
@rootelement now sorting params are optional and sorting by For example, request with sorting by
while the same request without sorting returns records:
|
@rootelement at the moment no resources are returned by this endpoint even without sorting params for any challenge. |
@ThomasKranitsas at the moment Resouces API doesn't return any resources with or without scoring params. It always returns 0 resources for all the challenges on DEV. |
Hey @maxceem, seems like there was a change on the API in order to support sorting but in order for this to work we need to update the mappings in ES and reindex the data. I have temporarily reset this change so the API works again. cc @rootelement |
Thanks, @ThomasKranitsas. Now Resource API returns data for me as before. Though I can still reproduce this issue for some challenges. I'm not sure if this is connected with the issue, or should I log a new issue for this. |
No, no need for a new issue. Seems like a recent change broke something.. I'll investigate and fix |
@maxceem is this unblocked now? Can you finish the admin in dev? |
@rootelement this is not fixed yet. When I get resources without sorting it works: But when I apply sorting no results are returned: |
cc @rootelement |
We have a feature request for Admin App to be able to sort challenge resources by:
memberHandle
created
role text
alphabetically:Registered
,Submitter
,Observer
?@ThomasKranitsas @rootelement
The text was updated successfully, but these errors were encountered: