Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

アクセシビリティチェックが通らない部分がある #12

Open
toshi-pono opened this issue Feb 10, 2023 · 0 comments
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@toshi-pono
Copy link
Owner

CIからは抜いている部分で落ちる

  • backgroundimageとかを表示しているimg要素がlandmarkに囲まれていない
  • splideのli要素にrole="tabpanel"が当たってるけど、できないっぽい?
    img要素のやつ↓
     Object {
+     "description": "Ensures all page content is contained by landmarks",
+     "help": "All page content should be contained by landmarks",
+     "helpUrl": "https://dequeuniversity.com/rules/axe/4.6/region?application=playwright",
+     "id": "region",
+     "impact": "moderate",
+     "nodes": Array [
+       Object {
+         "all": Array [],
+         "any": Array [
+           Object {
+             "data": Object {
+               "isIframe": false,
+             },
+             "id": "region",
+             "impact": "moderate",
+             "message": "Some page content is not contained by landmarks",
+             "relatedNodes": Array [],
+           },
+         ],
+         "failureSummary": "Fix any of the following:
+   Some page content is not contained by landmarks",
+         "html": "<img alt=\"\" draggable=\"false\" src=\"/bg/tv.svg\" width=\"1920\" height=\"1080\" decoding=\"async\" data-nimg=\"1\" class=\"Background_bgImage__Y_wYE\" style=\"color:transparent\">",
+         "impact": "moderate",
+         "none": Array [],
+         "target": Array [
+           ".Background_bgImage__Y_wYE",
+         ],
+       },

tabpanelのやつ↓

     Object {
+     "description": "Ensures role attribute has an appropriate value for the element",
+     "help": "ARIA role should be appropriate for the element",
+     "helpUrl": "https://dequeuniversity.com/rules/axe/4.6/aria-allowed-role?application=playwright",
+     "id": "aria-allowed-role",
+     "impact": "minor",
+     "nodes": Array [
+       Object {
+         "all": Array [],
+         "any": Array [
+           Object {
+             "data": Array [
+               "tabpanel",
+             ],
+             "id": "aria-allowed-role",
+             "impact": "minor",
+             "message": "ARIA role tabpanel is not allowed for given element",
+             "relatedNodes": Array [],
+           },
+         ],
+         "failureSummary": "Fix any of the following:
+   ARIA role tabpanel is not allowed for given element",
+         "html": "<li class=\"splide__slide is-active is-visible\" id=\"splide01-slide01\" role=\"tabpanel\" aria-roledescription=\"slide\" aria-label=\"1 of 4\" style=\"width: calc(100%);\">",
+         "impact": "minor",
+         "none": Array [],
+         "target": Array [
+           "#splide01-slide01",
+         ],
+       },
+     ],
+     "tags": Array [
+       "cat.aria",
+       "best-practice",
+     ],
+   },
@toshi-pono toshi-pono added bug Something isn't working enhancement New feature or request labels Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant