move JET tests front so that new methods do not cause failure

Author: tpapp

CHANGELOG.md

@@ -1,4 +1,18 @@
-# Unreleased
+## Unreleased
+
+### Added
+### Changed
+### Deprecated
+### Removed
+### Fixed
+
+- JET tests up front so that method extensions do not confuse it
+
+### Security
+
+# v3.5.1
+
+**No changelog was kept after v3.3.0,** it should be reconstructed from commits.
 
 # v3.3.0
 

test/runtests.jl

@@ -10,6 +10,22 @@ using DynamicHMC.Diagnostics: ACCEPTANCE_QUANTILES
 using LogDensityProblems: logdensity_and_gradient, dimension, LogDensityProblems
 using LogDensityTestSuite
 
+####
+#### static analysis and QA; before everything else as tests extend methods
+####
+
+@testset "static analysis with JET.jl" begin
+    using JET
+    @test isempty(JET.get_reports(report_package(DynamicHMC, target_modules=(DynamicHMC,))))
+end
+
+@testset "Aqua" begin
+    import Aqua
+    Aqua.test_all(DynamicHMC; ambiguities = false)
+    # testing separately, cf https://github.com/JuliaTesting/Aqua.jl/issues/77
+    Aqua.test_ambiguities(DynamicHMC)
+end
+
 ###
 ### general test environment
 ###
@@ -39,19 +55,3 @@ include("test_logging.jl")
 ####
 
 include("sample-correctness_tests.jl")
-
-####
-#### static analysis and QA
-####
-
-@testset "static analysis with JET.jl" begin
-    using JET
-    @test isempty(JET.get_reports(report_package(DynamicHMC, target_modules=(DynamicHMC,))))
-end
-
-@testset "Aqua" begin
-    import Aqua
-    Aqua.test_all(DynamicHMC; ambiguities = false)
-    # testing separately, cf https://github.com/JuliaTesting/Aqua.jl/issues/77
-    Aqua.test_ambiguities(DynamicHMC)
-end

test/test_trees.jl

@@ -44,13 +44,17 @@ Base.empty!(trajectory) = empty(trajectory.visited)
 
 DynamicHMC.move(::DummyTrajectory, z, is_forward) = z + (is_forward ? 1 : -1)
 
-function DynamicHMC.is_turning(::DummyTrajectory, τ)
+const DUMMY_TURN_STATISTICS = Tuple{Bool,UnitRange{Int64}}
+
+function DynamicHMC.is_turning(::DummyTrajectory, τ::DUMMY_TURN_STATISTICS)
     turn_flag, positions = τ
     @test length(positions) > 1 # not called on a leaf
     turn_flag
 end
 
-function DynamicHMC.combine_turn_statistics(::DummyTrajectory, τ₁, τ₂)
+function DynamicHMC.combine_turn_statistics(::DummyTrajectory,
+                                            τ₁::DUMMY_TURN_STATISTICS,
+                                            τ₂::DUMMY_TURN_STATISTICS)
     turn_flag1, positions1 = τ₁
     turn_flag2, positions2 = τ₂
     @test last(positions1) + 1 == first(positions2) # adjacency and order