+172
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akimon658
requested changes
Feb 11, 2025
| return echo.NewHTTPError(http.StatusBadRequest, "Bad request") | ||
| } | ||
|
|
||
| var updatedOption model.Option |
There was a problem hiding this comment.
#162 (comment) と同じ理由で、一旦既存のOptionを持ってきてほしいです。今はOption単体を取得する関数がないので、それを追加する必要もありそう 👀
Suggested change
| var updatedOption model.Option | |
| updatedOption, err := s.repo.GetOption(uint(optionID)) | |
| if err != nil { | |
| if errors.Is(err, model.ErrNotFound) { | |
| return echo.NewHTTPError(http.StatusNotFound, "Not found") | |
| } | |
| e.Logger().Errorf("failed to get option: %v", err) | |
| return echo.NewHTTPError(http.StatusInternalServerError, "Internal server error") | |
| } |
これはRequest bodyに |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
更新なんですが、選択肢のidと選択肢をもつ質問のidをどちらも取得しています。
片方だけでも動きはするなと思いました。
アンケートの編集の際に必要だったので作成しました
Closes #68