Skip to content

Commit c0c126e

Browse files
authored
Don't use <h1> in Uppy markup (#5355)
* everywhere - don't use `<h1>` in Uppy markup * `/dev/Dashboard.js` - add defence against using heading tags
1 parent 160cf16 commit c0c126e

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

packages/@uppy/audio/src/PermissionsScreen.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ export default (props: PermissionsScreenProps) => {
1212
return (
1313
<div className="uppy-Audio-permissons">
1414
<div className="uppy-Audio-permissonsIcon">{icon()}</div>
15-
<h1 className="uppy-Audio-title">
15+
<div className="uppy-Audio-title">
1616
{hasAudio ? i18n('allowAudioAccessTitle') : i18n('noAudioTitle')}
17-
</h1>
17+
</div>
1818
<p>
1919
{hasAudio ?
2020
i18n('allowAudioAccessDescription')

packages/@uppy/webcam/src/PermissionsScreen.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ export default function PermissionsScreen({
1515
return (
1616
<div className="uppy-Webcam-permissons">
1717
<div className="uppy-Webcam-permissonsIcon">{icon()}</div>
18-
<h1 className="uppy-Webcam-title">
18+
<div className="uppy-Webcam-title">
1919
{hasCamera ? i18n('allowAccessTitle') : i18n('noCameraTitle')}
20-
</h1>
20+
</div>
2121
<p>
2222
{hasCamera ?
2323
i18n('allowAccessDescription')

private/dev/index.html

+9-2
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,14 @@
2222
margin: auto;
2323
}
2424

25+
/* css to make sure that Dashboard's css overrides page css */
2526
button,
2627
input {
2728
color: green;
2829
font-size: 30px;
2930
text-align: right;
3031
border: 2px solid purple;
3132
}
32-
33-
/* css to make sure that Dashboard's css overrides page css */
3433
ul {
3534
margin: 60px;
3635
}
@@ -40,6 +39,14 @@
4039
a {
4140
color: purple;
4241
}
42+
h1,
43+
h2,
44+
h3,
45+
h4,
46+
h5,
47+
h6 {
48+
color: green;
49+
}
4350
</style>
4451
</head>
4552

0 commit comments

Comments
 (0)