Test on windows (#32)

Author: alex-treebeard

.github/workflows/publish-to-pypi.yml

@@ -9,7 +9,15 @@ jobs:
       - uses: actions/checkout@master
       - uses: actions/setup-python@v2
       - run: pip install poetry
+      - run: poetry version ${GITHUB_REF:10}
       - run: poetry build
       - uses: pypa/gh-action-pypi-publish@master
         with:
           password: ${{ secrets.PYPI_PASSWORD }}
+      - uses: EndBug/[email protected]
+        with:
+            author_name: github-actions
+            author_email: 41898282+github-actions[bot]@users.noreply.github.com
+            add: pyproject.toml
+            branch: main
+            message: Published new version

.github/workflows/pytest.yml

@@ -11,6 +11,14 @@ jobs:
       fail-fast: false
       matrix:
         cfg:
+          - os: windows-latest
+            python-version: "3.6"
+          - os: windows-latest
+            python-version: "3.7"
+          - os: windows-latest
+            python-version: "3.8"
+          - os: windows-latest
+            python-version: "3.9"
           - os: ubuntu-latest
             python-version: "3.6"
           - os: ubuntu-latest
@@ -37,23 +45,23 @@ jobs:
           python-version: ${{ matrix.cfg.python-version }}
       - run: pip install poetry
       - run: poetry install
-      - uses: pre-commit/[email protected]
+      - if: matrix.cfg.os != 'windows-latest'
+        uses: pre-commit/[email protected]
         with:
           extra_args: --verbose --all-files
 
       - run: poetry run pytest tests/test_nb_run.py # run without extras
       - run: poetry install
       - run: poetry run pytest --cov-report=xml --cov=src
-
-      - run: poetry run python -m ipykernel install --user --name nbmake
-      - run: poetry run jb build -W -n --keep-going --builder html docs
-
       - uses: codecov/codecov-action@v1
         with:
           file: coverage.xml
 
-      - name: GitHub Pages action
-        if: github.ref == 'refs/heads/main' && matrix.cfg.publish-docs
+      - if: github.ref == 'refs/heads/main' && matrix.cfg.publish-docs
+        run: |
+          poetry run python -m ipykernel install --user --name nbmake
+          poetry run jb build -W -n --keep-going --builder html docs
+      - if: github.ref == 'refs/heads/main' && matrix.cfg.publish-docs
         uses: peaceiris/[email protected]
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
@@ -96,7 +104,6 @@ jobs:
             -n=auto \
             teachopencadd/talktorials/T000_template/talktorial.ipynb \
             teachopencadd/talktorials/T002_compound_adme/talktorial.ipynb \
-            teachopencadd/talktorials/T003_compound_unwanted_substructures/talktorial.ipynb \
             teachopencadd/talktorials/T004_compound_similarity/talktorial.ipynb \
             teachopencadd/talktorials/T005_compound_clustering/talktorial.ipynb \
             teachopencadd/talktorials/T007_compound_activity_machine_learning/talktorial.ipynb \

README.md

@@ -9,8 +9,6 @@
 
 **Who is this for?** Research/Machine Learning Software Engineers who maintain packages/teaching materials with documentation written in notebooks.
 
-**⚠️ Warning: Does not support Windows**
-
 ## Functionality
 
 1. Executes notebooks using pytest and nbclient, allowing parallel notebook testing

pytest.ini

@@ -1,3 +1,4 @@
 [pytest]
 testpaths =
-    tests
+    tests
+timeout = 180

src/nbmake/pytest_plugin.py

@@ -1,10 +1,21 @@
+import asyncio
+import sys
 from pathlib import Path
 from typing import Any, Optional
 
 from .pytest_items import NotebookFile
 
 
 def pytest_addoption(parser: Any):
+    # See https://bugs.python.org/issue37373 and
+    # https://github.com/nteract/papermill/issues/515
+    if (
+        sys.version_info[0] == 3
+        and sys.version_info[1] >= 8
+        and sys.platform.startswith("win")
+    ):
+        asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy())
+
     group = parser.getgroup("nbmake", "notebook testing")
     group.addoption(
         "--nbmake", action="store_true", help="Test notebooks", default=False