Skip to content

Commit 24f99c0

Browse files
authored
Fix rsync_exclude for gcp credential file_mounts (skypilot-org#496)
* Fix rsync_exclude for gcp credential file_mounts * fix comment * address comment
1 parent bf0aa61 commit 24f99c0

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

sky/clouds/gcp.py

+7-3
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,10 @@ def check_credentials(self) -> Tuple[bool, Optional[str]]:
256256
return True, None
257257

258258
def get_credential_file_mounts(self) -> Tuple[Dict[str, str], List[str]]:
259-
return {
260-
'~/.config/gcloud': '~/.config/gcloud'
261-
}, ['~/.config/gcloud/virtenv']
259+
# Excluding the symlink to the python executable created by the gcp
260+
# credential, which causes problem for ray up multiple nodes, tracked
261+
# in #494, #496, #483.
262+
# rsync_exclude only supports relative paths.
263+
# TODO(zhwu): rsync_exclude here is unsafe as it may exclude the folder
264+
# from other file_mounts as well in ray yaml.
265+
return {'~/.config/gcloud': '~/.config/gcloud'}, ['virtenv']

0 commit comments

Comments
 (0)