Skip to content

Commit 9fca91b

Browse files
authored
Upgrade default CPU instance types (skypilot-org#1613)
* Upgrade default instance types * Fix optimizer test
1 parent 089f2b5 commit 9fca91b

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

sky/clouds/aws.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,8 @@ def is_same_cloud(self, other: clouds.Cloud):
275275

276276
@classmethod
277277
def get_default_instance_type(cls) -> str:
278-
# 8 vCpus, 32 GB RAM. 3rd generation Intel Xeon. General Purpose.
278+
# General-purpose instance with 8 vCPUs and 32 GB RAM.
279+
# Intel Ice Lake 8375C
279280
return 'm6i.2xlarge'
280281

281282
# TODO: factor the following three methods, as they are the same logic

sky/clouds/azure.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,9 @@ def is_same_cloud(self, other):
9595

9696
@classmethod
9797
def get_default_instance_type(cls) -> str:
98-
# 8 vCpus, 32 GB RAM. Prev-gen (as of 2021) general purpose.
99-
return 'Standard_D8_v4'
98+
# General-purpose instance with 8 vCPUs and 32 GB RAM.
99+
# Intel Ice Lake 8370C
100+
return 'Standard_D8_v5'
100101

101102
def _get_image_config(self, gen_version, instance_type):
102103
# az vm image list \

sky/clouds/gcp.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,8 +280,9 @@ def get_image_size(self, image_id: str, region: Optional[str]) -> float:
280280

281281
@classmethod
282282
def get_default_instance_type(cls) -> str:
283-
# 8 vCpus, 52 GB RAM. First-gen general purpose.
284-
return 'n1-highmem-8'
283+
# General-purpose instance with 8 vCPUs and 32 GB RAM.
284+
# Intel Ice Lake 8373C or Cascade Lake 6268CL
285+
return 'n2-standard-8'
285286

286287
@classmethod
287288
def _get_default_region(cls) -> clouds.Region:

tests/test_optimizer_random_dag.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
'Azure': sky.Azure(),
1313
}
1414
ALL_INSTANCE_TYPES = sum(sky.list_accelerators(gpus_only=True).values(), [])
15-
GCP_DEFAULT_INSTANCE_TYPE = sky.GCP.get_default_instance_type()
15+
GCP_HOST_VM = 'n1-highmem-8'
1616

1717
DUMMY_NODES = [
1818
sky.optimizer._DUMMY_SOURCE_NAME,
@@ -67,7 +67,7 @@ def generate_random_dag(
6767
for candidate in candidate_instance_types:
6868
instance_type = candidate.instance_type
6969
if pd.isna(instance_type):
70-
instance_type = GCP_DEFAULT_INSTANCE_TYPE
70+
instance_type = GCP_HOST_VM
7171
resources = sky.Resources(
7272
cloud=CLOUDS[candidate.cloud],
7373
instance_type=instance_type,

0 commit comments

Comments
 (0)