Skip to content

Commit 0b86108

Browse files
treetipsusername
and
username
authored
Feature/support for react in eslint (#3)
* refactor: add support for react in ESLint * refactor: fix warnings of ESLint rules Co-authored-by: username <[email protected]>
1 parent 6f01f0c commit 0b86108

9 files changed

+187
-5
lines changed

.eslintrc.js

+13-2
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,18 @@ module.exports = {
33
parserOptions: {
44
project: "tsconfig.json",
55
sourceType: "module",
6+
ecmaFeatures: {
7+
jsx: true,
8+
},
9+
useJSXTextNode: true,
610
},
7-
plugins: ["@typescript-eslint/eslint-plugin"],
11+
plugins: ["@typescript-eslint/eslint-plugin", "react"],
812
extends: [
913
"plugin:@typescript-eslint/eslint-recommended",
1014
"plugin:@typescript-eslint/recommended",
11-
"prettier",
1215
"prettier/@typescript-eslint",
16+
"plugin:react/recommended",
17+
"prettier/react",
1318
],
1419
root: true,
1520
env: {
@@ -20,5 +25,11 @@ module.exports = {
2025
"@typescript-eslint/interface-name-prefix": "off",
2126
"@typescript-eslint/explicit-function-return-type": "off",
2227
"@typescript-eslint/no-explicit-any": "off",
28+
"@typescript-eslint/no-unused-vars": [
29+
"error",
30+
{
31+
argsIgnorePattern: "^_",
32+
},
33+
],
2334
},
2435
}

components/atoms/SpacingPaper.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { Paper } from "@material-ui/core"
22
import { createStyles, makeStyles, Theme } from "@material-ui/core/styles"
3+
import React from "react"
34

45
const useStyles = makeStyles<Theme, Props>((theme: Theme) =>
56
createStyles({

components/organisms/HeaderArticleContainer.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { createStyles, makeStyles, Theme } from "@material-ui/core/styles"
2+
import React from "react"
23
import { PageHeader } from "../molecules"
34

45
const useStyles = makeStyles((theme: Theme) =>

components/organisms/Sidenavi.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { List } from "@material-ui/core"
22
import { createStyles, makeStyles, Theme } from "@material-ui/core/styles"
33
import SvgIcon from "@material-ui/core/SvgIcon"
4+
import React from "react"
45
import { Page, SiteInfo } from "../../constants"
56
import { usePage } from "../../hooks"
67
import { NextListItem } from "../molecules"

components/templates/Layout.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { createStyles, makeStyles, Theme } from "@material-ui/core/styles"
22
import Head from "next/head"
3-
import * as React from "react"
3+
import React from "react"
44
import { usePage } from "../../hooks"
55
import { ResponsiveDrawer } from "../organisms"
66

package-lock.json

+165
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+3-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"build": "next build",
99
"start": "NODE_ENV=production node server.js",
1010
"format": "prettier --write \"{components,constants,hooks,model,pages,store,types}/**/*.{ts,tsx}\"",
11-
"lint": "eslint \"{components,constants,hooks,model,pages,store,types}/**/*.ts\" --fix"
11+
"lint": "eslint \"{components,constants,hooks,model,pages,store,types}/**/*.{ts,tsx}\" --fix"
1212
},
1313
"keywords": [],
1414
"author": "",
@@ -44,6 +44,8 @@
4444
"eslint": "^7.0.0",
4545
"eslint-config-prettier": "^6.11.0",
4646
"eslint-plugin-import": "^2.20.2",
47+
"eslint-plugin-prettier": "^3.1.3",
48+
"eslint-plugin-react": "^7.19.0",
4749
"prettier": "^2.0.5",
4850
"typescript": "^3.8.3"
4951
}

pages/index.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { Typography } from "@material-ui/core"
22
import { createStyles, makeStyles, Theme } from "@material-ui/core/styles"
3+
import React from "react"
34
import { AppContext } from "../components/AppContext"
45
import { SpacingPaper } from "../components/atoms"
56
import { HeaderArticleContainer } from "../components/organisms"

store/configureStore.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ const store = configureStore({
1818
devTools: Env.NODE_ENV === "development",
1919
})
2020

21-
export const makeStore: MakeStore = (): EnhancedStore => store
21+
export const makeStore: MakeStore = (_?: RootState): EnhancedStore => store

0 commit comments

Comments
 (0)