Skip to content

Commit e4a3f0f

Browse files
committed
Rename variable to clarify it's the schema_name
1 parent 7154c0a commit e4a3f0f

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

tests/integration/test_sqlalchemy_integration.py

+12-12
Original file line numberDiff line numberDiff line change
@@ -374,11 +374,11 @@ def test_get_table_comment(trino_connection):
374374
@pytest.mark.parametrize('schema', [None, 'test'])
375375
def test_get_table_names(trino_connection, schema):
376376
engine, conn = trino_connection
377-
name = schema or engine.dialect._get_default_schema_name(conn)
378-
metadata = sqla.MetaData(schema=name)
377+
schema_name = schema or engine.dialect._get_default_schema_name(conn)
378+
metadata = sqla.MetaData(schema=schema_name)
379379

380-
if not engine.dialect.has_schema(conn, name):
381-
engine.execute(sqla.schema.CreateSchema(name))
380+
if not engine.dialect.has_schema(conn, schema_name):
381+
engine.execute(sqla.schema.CreateSchema(schema_name))
382382

383383
try:
384384
sqla.Table(
@@ -387,9 +387,9 @@ def test_get_table_names(trino_connection, schema):
387387
sqla.Column('id', sqla.Integer),
388388
)
389389
metadata.create_all(engine)
390-
view_name = name + ".test_view"
390+
view_name = schema_name + ".test_view"
391391
conn.execute(f"CREATE VIEW {view_name} AS SELECT * FROM test_get_table_names")
392-
assert sqla.inspect(engine).get_table_names(name) == ['test_get_table_names']
392+
assert sqla.inspect(engine).get_table_names(schema_name) == ['test_get_table_names']
393393
finally:
394394
conn.execute(f"DROP VIEW IF EXISTS {view_name}")
395395
metadata.drop_all(engine)
@@ -407,11 +407,11 @@ def test_get_table_names_raises(trino_connection):
407407
@pytest.mark.parametrize('schema', [None, 'test'])
408408
def test_get_view_names(trino_connection, schema):
409409
engine, conn = trino_connection
410-
name = schema or engine.dialect._get_default_schema_name(conn)
411-
metadata = sqla.MetaData(schema=name)
410+
schema_name = schema or engine.dialect._get_default_schema_name(conn)
411+
metadata = sqla.MetaData(schema=schema_name)
412412

413-
if not engine.dialect.has_schema(conn, name):
414-
engine.execute(sqla.schema.CreateSchema(name))
413+
if not engine.dialect.has_schema(conn, schema_name):
414+
engine.execute(sqla.schema.CreateSchema(schema_name))
415415

416416
try:
417417
sqla.Table(
@@ -420,9 +420,9 @@ def test_get_view_names(trino_connection, schema):
420420
sqla.Column('id', sqla.Integer),
421421
)
422422
metadata.create_all(engine)
423-
view_name = name + ".test_get_view_names"
423+
view_name = schema_name + ".test_get_view_names"
424424
conn.execute(f"CREATE VIEW {view_name} AS SELECT * FROM test_table")
425-
assert sqla.inspect(engine).get_view_names(name) == ['test_get_view_names']
425+
assert sqla.inspect(engine).get_view_names(schema_name) == ['test_get_view_names']
426426
finally:
427427
conn.execute(f"DROP VIEW IF EXISTS {view_name}")
428428
metadata.drop_all(engine)

0 commit comments

Comments
 (0)