Rename BaseJdbcClient.getTableSchemaName to clarify

Rename `BaseJdbcClient.getTableSchemaName` to `getTableRemoteSchemaName`
to clarify its semantics. In particular, Trino doesn't currently support
non-lowercase schema names, yet the function is not expected to
lowercase.

This is a breaking change for anyone overriding or calling this method.

Author: findepi

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java

@@ -213,7 +213,7 @@ public List<RelationCommentMetadata> getAllTableComments(ConnectorSession sessio
             try (ResultSet resultSet = getTables(connection, remoteSchema, Optional.empty())) {
                 ImmutableList.Builder<RelationCommentMetadata> list = ImmutableList.builder();
                 while (resultSet.next()) {
-                    String remoteSchemaFromResultSet = getTableSchemaName(resultSet);
+                    String remoteSchemaFromResultSet = getTableRemoteSchemaName(resultSet);
                     String tableSchema = identifierMapping.fromRemoteSchemaName(remoteSchemaFromResultSet);
                     String tableName = identifierMapping.fromRemoteTableName(remoteSchemaFromResultSet, resultSet.getString("TABLE_NAME"));
                     if (filterRemoteSchema(remoteSchemaFromResultSet)) {
@@ -387,7 +387,7 @@ public Iterator<RelationColumnsMetadata> getAllTableColumns(ConnectorSession ses
             ImmutableSet.Builder<RemoteTableName> visibleTables = ImmutableSet.builder();
             try (ResultSet tablesResultSet = getTables(connection, remoteSchema, Optional.empty())) {
                 while (tablesResultSet.next()) {
-                    if (filterRemoteSchema(getTableSchemaName(tablesResultSet))) {
+                    if (filterRemoteSchema(getTableRemoteSchemaName(tablesResultSet))) {
                         visibleTables.add(getRemoteTable(tablesResultSet));
                     }
                 }
@@ -448,7 +448,7 @@ protected RelationColumnsMetadata computeNext()
                     try {
                         if (currentTable == null) {
                             currentTable = nextTable;
-                            String remoteSchemaFromResultSet = getTableSchemaName(resultSet);
+                            String remoteSchemaFromResultSet = getTableRemoteSchemaName(resultSet);
                             currentTableVisible = visibleTables.contains(nextTable);
                             if (currentTableVisible) {
                                 currentTableName = new SchemaTableName(
@@ -1535,7 +1535,7 @@ protected Optional<List<String>> getTableTypes()
         return Optional.of(ImmutableList.of("TABLE", "VIEW"));
     }
 
-    protected String getTableSchemaName(ResultSet resultSet)
+    protected String getTableRemoteSchemaName(ResultSet resultSet)
             throws SQLException
     {
         return resultSet.getString("TABLE_SCHEM");

plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java

@@ -308,7 +308,7 @@ public ResultSet getTables(Connection connection, Optional<String> schemaName, O
     }
 
     @Override
-    protected String getTableSchemaName(ResultSet resultSet)
+    protected String getTableRemoteSchemaName(ResultSet resultSet)
             throws SQLException
     {
         return resultSet.getString("TABLE_CAT");

plugin/trino-mariadb/src/main/java/io/trino/plugin/mariadb/MariaDbClient.java

@@ -326,7 +326,7 @@ protected ResultSet getAllTableColumns(Connection connection, Optional<String> r
     }
 
     @Override
-    protected String getTableSchemaName(ResultSet resultSet)
+    protected String getTableRemoteSchemaName(ResultSet resultSet)
             throws SQLException
     {
         // MariaDB uses catalogs instead of schemas

plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java

@@ -474,7 +474,7 @@ public void setTableComment(ConnectorSession session, JdbcTableHandle handle, Op
     }
 
     @Override
-    protected String getTableSchemaName(ResultSet resultSet)
+    protected String getTableRemoteSchemaName(ResultSet resultSet)
             throws SQLException
     {
         // MySQL uses catalogs instead of schemas

plugin/trino-singlestore/src/main/java/io/trino/plugin/singlestore/SingleStoreClient.java

@@ -480,7 +480,7 @@ public void renameSchema(ConnectorSession session, String schemaName, String new
     }
 
     @Override
-    protected String getTableSchemaName(ResultSet resultSet)
+    protected String getTableRemoteSchemaName(ResultSet resultSet)
             throws SQLException
     {
         // SingleStore uses catalogs instead of schemas