fix(test): release resource of testcases gracefully (#6437)

* delete BaseNet, BaseNetTest

* release resource of gRPC

* optimize testcase to reduce the time cost

* delete db after testcase in tmp dir; short the time cost of some case; optimize some shutdown action

* use shutdownnow instead of shutdown in close Channel

Author: 317787106

chainbase/src/main/java/org/tron/core/db2/core/SnapshotManager.java

@@ -427,6 +427,9 @@ public List<String> getCheckpointList() {
   }
 
   private void deleteCheckpoint() {
+    if(checkTmpStore == null) {
+      return;
+    }
     try {
       Map<byte[], byte[]> hmap = new HashMap<>();
       for (Map.Entry<byte[], byte[]> e : checkTmpStore.getDbSource()) {

common/src/main/java/org/tron/common/logsfilter/FilterQuery.java

@@ -31,12 +31,7 @@ public static long parseFromBlockNumber(String blockNum) {
     if (StringUtils.isEmpty(blockNum) || FilterQuery.EARLIEST.equalsIgnoreCase(blockNum)) {
       number = FilterQuery.EARLIEST_BLOCK_NUM;
     } else {
-      try {
-        number = Long.parseLong(blockNum);
-      } catch (Exception e) {
-        logger.error("invalid filter: fromBlockNumber: {}", blockNum);
-        throw e;
-      }
+      number = Long.parseLong(blockNum);
     }
     return number;
   }
@@ -46,12 +41,7 @@ public static long parseToBlockNumber(String blockNum) {
     if (StringUtils.isEmpty(blockNum) || FilterQuery.LATEST.equalsIgnoreCase(blockNum)) {
       number = FilterQuery.LATEST_BLOCK_NUM;
     } else {
-      try {
-        number = Long.parseLong(blockNum);
-      } catch (Exception e) {
-        logger.error("invalid filter: toBlockNumber: {}", blockNum);
-        throw e;
-      }
+      number = Long.parseLong(blockNum);
     }
     return number;
   }

framework/src/main/java/org/tron/common/application/TronApplicationContext.java

@@ -13,8 +13,10 @@ public TronApplicationContext(DefaultListableBeanFactory beanFactory) {
     super(beanFactory);
   }
 
+  //only used for testcase
   public TronApplicationContext(Class<?>... annotatedClasses) {
     super(annotatedClasses);
+    this.registerShutdownHook();
   }
 
   public TronApplicationContext(String... basePackages) {

framework/src/main/java/org/tron/common/logsfilter/EventPluginLoader.java

@@ -9,7 +9,6 @@
 import java.util.Objects;
 import java.util.Set;
 import java.util.stream.Collectors;
-
 import lombok.Getter;
 import lombok.extern.slf4j.Slf4j;
 import org.bouncycastle.util.encoders.Hex;
@@ -26,7 +25,6 @@
 import org.tron.common.logsfilter.trigger.SolidityTrigger;
 import org.tron.common.logsfilter.trigger.TransactionLogTrigger;
 import org.tron.common.logsfilter.trigger.Trigger;
-import org.tron.common.utils.JsonUtil;
 
 @Slf4j
 public class EventPluginLoader {
@@ -140,7 +138,7 @@ public static boolean matchFilter(ContractTrigger trigger) {
 
   private static boolean filterContractAddress(ContractTrigger trigger, List<String> addressList) {
     addressList = addressList.stream().filter(item ->
-        org.apache.commons.lang3.StringUtils.isNotEmpty(item))
+            org.apache.commons.lang3.StringUtils.isNotEmpty(item))
         .collect(Collectors.toList());
     if (Objects.isNull(addressList) || addressList.isEmpty()) {
       return true;
@@ -173,7 +171,7 @@ private static boolean filterContractTopicList(ContractTrigger trigger, List<Str
       hset = new HashSet<>(((ContractEventTrigger) trigger).getTopicMap().values());
     } else if (trigger != null) {
       hset = trigger.getLogInfo().getClonedTopics()
-              .stream().map(Hex::toHexString).collect(Collectors.toSet());
+          .stream().map(Hex::toHexString).collect(Collectors.toSet());
     }
 
     for (String top : topList) {
@@ -547,6 +545,9 @@ public boolean isBusy() {
       return false;
     }
     int queueSize = 0;
+    if (eventListeners == null || eventListeners.isEmpty()) {
+      return false;
+    }
     for (IPluginEventListener listener : eventListeners) {
       try {
         queueSize += listener.getPendingSize();

framework/src/main/java/org/tron/core/config/args/Args.java

@@ -1621,7 +1621,7 @@ private static FilterQuery getEventFilter(final com.typesafe.config.Config confi
     try {
       fromBlockLong = FilterQuery.parseFromBlockNumber(fromBlock);
     } catch (Exception e) {
-      logger.error("{}", e);
+      logger.error("invalid filter: fromBlockNumber: {}", fromBlock, e);
       return null;
     }
     filter.setFromBlock(fromBlockLong);
@@ -1630,7 +1630,7 @@ private static FilterQuery getEventFilter(final com.typesafe.config.Config confi
     try {
       toBlockLong = FilterQuery.parseToBlockNumber(toBlock);
     } catch (Exception e) {
-      logger.error("{}", e);
+      logger.error("invalid filter: toBlockNumber: {}", toBlock, e);
       return null;
     }
     filter.setToBlock(toBlockLong);

framework/src/test/java/org/tron/common/EntityTest.java

@@ -5,13 +5,16 @@
 import static org.junit.Assert.assertTrue;
 
 import com.google.common.collect.Lists;
+import java.util.ArrayList;
 import java.util.HashMap;
+import java.util.List;
 import org.apache.commons.collections4.CollectionUtils;
 import org.junit.Before;
 import org.junit.Test;
 import org.tron.common.entity.NodeInfo;
 import org.tron.common.entity.NodeInfo.MachineInfo;
 import org.tron.common.entity.NodeInfo.MachineInfo.DeadLockThreadInfo;
+import org.tron.common.entity.PeerInfo;
 
 public class EntityTest {
 
@@ -54,6 +57,9 @@ public void testDeadLockThreadInfo() {
 
   @Test
   public void testNodeInfo() {
+    List<PeerInfo> peerInfoList = new ArrayList<>();
+    peerInfoList.add(getDefaultPeerInfo());
+
     NodeInfo nodeInfo = new NodeInfo();
     nodeInfo.setTotalFlow(1L);
     nodeInfo.setCheatWitnessInfoMap(new HashMap<>());
@@ -62,6 +68,39 @@ public void testNodeInfo() {
     nodeInfo.setMachineInfo(machineInfo);
     nodeInfo.setBlock("block");
     nodeInfo.setSolidityBlock("solidityBlock");
+    nodeInfo.setPeerList(peerInfoList);
     nodeInfo.transferToProtoEntity();
   }
+
+  private PeerInfo getDefaultPeerInfo() {
+    PeerInfo peerInfo = new PeerInfo();
+    peerInfo.setAvgLatency(peerInfo.getAvgLatency());
+    peerInfo.setBlockInPorcSize(peerInfo.getBlockInPorcSize());
+    peerInfo.setConnectTime(peerInfo.getConnectTime());
+    peerInfo.setDisconnectTimes(peerInfo.getDisconnectTimes());
+    peerInfo.setHeadBlockTimeWeBothHave(peerInfo.getHeadBlockTimeWeBothHave());
+    peerInfo.setHeadBlockWeBothHave(peerInfo.getHeadBlockWeBothHave());
+    peerInfo.setHost("host");
+    peerInfo.setInFlow(peerInfo.getInFlow());
+    peerInfo.setLastBlockUpdateTime(peerInfo.getLastBlockUpdateTime());
+    peerInfo.setLastSyncBlock("last");
+    peerInfo.setLocalDisconnectReason("localDisconnectReason");
+    peerInfo.setNodeCount(peerInfo.getNodeCount());
+    peerInfo.setNodeId("nodeId");
+    peerInfo.setHeadBlockWeBothHave("headBlockWeBothHave");
+    peerInfo.setRemainNum(peerInfo.getRemainNum());
+    peerInfo.setRemoteDisconnectReason("remoteDisconnectReason");
+    peerInfo.setScore(peerInfo.getScore());
+    peerInfo.setPort(peerInfo.getPort());
+    peerInfo.setSyncFlag(peerInfo.isSyncFlag());
+    peerInfo.setNeedSyncFromPeer(peerInfo.isNeedSyncFromPeer());
+    peerInfo.setNeedSyncFromUs(peerInfo.isNeedSyncFromUs());
+    peerInfo.setSyncToFetchSize(peerInfo.getSyncToFetchSize());
+    peerInfo.setSyncToFetchSizePeekNum(peerInfo.getSyncToFetchSizePeekNum());
+    peerInfo.setSyncBlockRequestedSize(peerInfo.getSyncBlockRequestedSize());
+    peerInfo.setUnFetchSynNum(peerInfo.getUnFetchSynNum());
+    peerInfo.setActive(peerInfo.isActive());
+
+    return peerInfo;
+  }
 }

framework/src/test/java/org/tron/common/backup/BackupServerTest.java

@@ -10,6 +10,7 @@
 import org.junit.rules.Timeout;
 import org.tron.common.backup.socket.BackupServer;
 import org.tron.common.parameter.CommonParameter;
+import org.tron.common.utils.PublicMethod;
 import org.tron.core.Constant;
 import org.tron.core.config.args.Args;
 
@@ -26,7 +27,7 @@ public class BackupServerTest {
   @Before
   public void setUp() throws Exception {
     Args.setParam(new String[]{"-d", temporaryFolder.newFolder().toString()}, Constant.TEST_CONF);
-    CommonParameter.getInstance().setBackupPort(80);
+    CommonParameter.getInstance().setBackupPort(PublicMethod.chooseRandomPort());
     List<String> members = new ArrayList<>();
     members.add("127.0.0.2");
     CommonParameter.getInstance().setBackupMembers(members);

framework/src/test/java/org/tron/common/logsfilter/NativeMessageQueueTest.java

@@ -55,18 +55,19 @@ public void publishTrigger() {
 
   public void startSubscribeThread() {
     Thread thread = new Thread(() -> {
-      ZContext context = new ZContext();
-      ZMQ.Socket subscriber = context.createSocket(SocketType.SUB);
+      try (ZContext context = new ZContext()) {
+        ZMQ.Socket subscriber = context.createSocket(SocketType.SUB);
 
-      Assert.assertEquals(true, subscriber.connect(String.format("tcp://localhost:%d", bindPort)));
-      Assert.assertEquals(true, subscriber.subscribe(topic));
+        Assert.assertTrue(subscriber.connect(String.format("tcp://localhost:%d", bindPort)));
+        Assert.assertTrue(subscriber.subscribe(topic));
 
-      while (!Thread.currentThread().isInterrupted()) {
-        byte[] message = subscriber.recv();
-        String triggerMsg = new String(message);
-
-        Assert.assertEquals(true, triggerMsg.contains(dataToSend) || triggerMsg.contains(topic));
+        while (!Thread.currentThread().isInterrupted()) {
+          byte[] message = subscriber.recv();
+          String triggerMsg = new String(message);
 
+          Assert.assertTrue(triggerMsg.contains(dataToSend) || triggerMsg.contains(topic));
+        }
+        // ZMQ.Socket will be automatically closed when ZContext is closed
       }
     });
     thread.start();

framework/src/test/java/org/tron/common/utils/FileUtilTest.java

@@ -67,6 +67,7 @@ public void testReadData_NormalFile() throws IOException {
     try (FileWriter writer = new FileWriter(tempFile.toFile())) {
       writer.write("Hello, World!");
     }
+    tempFile.toFile().deleteOnExit();
 
     char[] buffer = new char[1024];
     int len = readData(tempFile.toString(), buffer);

framework/src/test/java/org/tron/common/utils/client/Configuration.java

@@ -4,7 +4,6 @@
 import com.typesafe.config.ConfigFactory;
 import java.io.File;
 import java.io.FileInputStream;
-import java.io.FileNotFoundException;
 import java.io.InputStreamReader;
 import org.apache.commons.lang3.StringUtils;
 import org.slf4j.Logger;
@@ -28,12 +27,12 @@ public static Config getByPath(final String configurationPath) {
     if (config == null) {
       File configFile = new File(System.getProperty("user.dir") + '/' + configurationPath);
       if (configFile.exists()) {
-        try {
-          config = ConfigFactory
-              .parseReader(new InputStreamReader(new FileInputStream(configurationPath)));
+        try (FileInputStream fis = new FileInputStream(configurationPath);
+            InputStreamReader isr = new InputStreamReader(fis)) {
+          config = ConfigFactory.parseReader(isr);
           logger.info("use user defined config file in current dir");
-        } catch (FileNotFoundException e) {
-          logger.error("load user defined config file exception: " + e.getMessage());
+        } catch (Exception e) {
+          logger.error("load user defined config file exception: {}", e.getMessage());
         }
       } else {
         config = ConfigFactory.load(configurationPath);