Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[common]: merge portal with chartContext and refactor #31880

Open
2 tasks done
PrivatePuffin opened this issue Feb 10, 2025 · 0 comments
Open
2 tasks done

feat[common]: merge portal with chartContext and refactor #31880

PrivatePuffin opened this issue Feb 10, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@PrivatePuffin
Copy link
Member

Is your feature request related to a problem?

We currently have both portal and chartContext which contain "derived" values, such as ways to reach the chart.
This gets used by the notes.txt to showcase how to reach a chart, for example.

However, this is too bloated.
portals should be part of chart-context and should be dynamic.

The portal info is also the thing that should be used when ranging over the hostnames a chart is available at, not ingress.
As we would soon be supporting both gateway-api AND ingress

Describe the solution you'd like

portals should be part of chart-context and should be dynamic.

  • Fetch all Loadbalancer-type services and their ports
  • Fetch all ingresses and the service+port they are linked to

Create an entry in portals:

  • If ingress has a service-port assigned, show the ingress hostname(s)
  • Else show loadbalancerIP+port

Describe alternatives you've considered

.

Additional context

If something has ingress, just assume https and port 443 (aka no port).

Currently we do all sorts of complicated fetching to figure out end-point URLs.
But if users want to go as far as having ingress (or gateway-API) on non-standardized ports, instead of just relying on host-name filtering, we shouldn't bother.

It creates a mess and would inherently create reliances on lookups we dont want.

This also means a support policy update:
"We do not support running ingress or gateway-api on any port other than 80/443 and only using https"

I've read and agree with the following

  • I've checked all open and closed issues and my request is not there.
  • I've checked all open and closed pull requests and my request is not there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant