Skip to content

Commit 588641f

Browse files
committed
Merge branch 'main' into ptr
2 parents bac78d3 + b8e08df commit 588641f

File tree

7 files changed

+51
-33
lines changed

7 files changed

+51
-33
lines changed

ElvUI/Cata/Modules/Skins/Menu.lua

+15-9
Original file line numberDiff line numberDiff line change
@@ -20,23 +20,29 @@ local function SkinFrame(frame)
2020
end
2121
end
2222

23-
local function OpenMenu(manager, region, menuDescription)
23+
function S:SkinMenu(manager, ownerRegion, menuDescription, anchor)
2424
local menu = manager:GetOpenMenu()
25-
if menu then
26-
-- Initial context menu
27-
SkinFrame(menu)
28-
-- SubMenus
29-
menuDescription:AddMenuAcquiredCallback(SkinFrame)
30-
end
25+
if not menu then return end
26+
27+
SkinFrame(menu) -- Initial context menu
28+
menuDescription:AddMenuAcquiredCallback(SkinFrame) -- SubMenus
29+
end
30+
31+
function S:OpenMenu(ownerRegion, menuDescription, anchor)
32+
S:SkinMenu(self, ownerRegion, menuDescription, anchor) -- self is manager (Menu.GetManager)
33+
end
34+
35+
function S:OpenContextMenu(ownerRegion, menuDescription)
36+
S:SkinMenu(self, ownerRegion, menuDescription) -- self is manager (Menu.GetManager)
3137
end
3238

3339
function S:Blizzard_Menu()
3440
if not (E.private.skins.blizzard.enable and E.private.skins.blizzard.misc) then return end
3541

3642
local manager = _G.Menu.GetManager()
3743
if manager then
38-
hooksecurefunc(manager, 'OpenMenu', OpenMenu)
39-
hooksecurefunc(manager, 'OpenContextMenu', OpenMenu)
44+
hooksecurefunc(manager, 'OpenMenu', S.OpenMenu)
45+
hooksecurefunc(manager, 'OpenContextMenu', S.OpenContextMenu)
4046
end
4147
end
4248

ElvUI/Classic/Modules/Skins/Menu.lua

+15-9
Original file line numberDiff line numberDiff line change
@@ -20,23 +20,29 @@ local function SkinFrame(frame)
2020
end
2121
end
2222

23-
local function OpenMenu(manager, region, menuDescription)
23+
function S:SkinMenu(manager, ownerRegion, menuDescription, anchor)
2424
local menu = manager:GetOpenMenu()
25-
if menu then
26-
-- Initial context menu
27-
SkinFrame(menu)
28-
-- SubMenus
29-
menuDescription:AddMenuAcquiredCallback(SkinFrame)
30-
end
25+
if not menu then return end
26+
27+
SkinFrame(menu) -- Initial context menu
28+
menuDescription:AddMenuAcquiredCallback(SkinFrame) -- SubMenus
29+
end
30+
31+
function S:OpenMenu(ownerRegion, menuDescription, anchor)
32+
S:SkinMenu(self, ownerRegion, menuDescription, anchor) -- self is manager (Menu.GetManager)
33+
end
34+
35+
function S:OpenContextMenu(ownerRegion, menuDescription)
36+
S:SkinMenu(self, ownerRegion, menuDescription) -- self is manager (Menu.GetManager)
3137
end
3238

3339
function S:Blizzard_Menu()
3440
if not (E.private.skins.blizzard.enable and E.private.skins.blizzard.misc) then return end
3541

3642
local manager = _G.Menu.GetManager()
3743
if manager then
38-
hooksecurefunc(manager, 'OpenMenu', OpenMenu)
39-
hooksecurefunc(manager, 'OpenContextMenu', OpenMenu)
44+
hooksecurefunc(manager, 'OpenMenu', S.OpenMenu)
45+
hooksecurefunc(manager, 'OpenContextMenu', S.OpenContextMenu)
4046
end
4147
end
4248

ElvUI/Core/Modules/Nameplates/Elements/CastBar.lua

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ function NP:Construct_Castbar(nameplate)
133133
local castbar = CreateFrame('StatusBar', '$parentCastbar', nameplate)
134134
castbar:SetFrameStrata(nameplate:GetFrameStrata())
135135
castbar:SetFrameLevel(5)
136-
castbar:CreateBackdrop('Transparent', nil, nil, nil, nil, true, true)
136+
castbar:CreateBackdrop('Transparent', nil, nil, nil, nil, true)
137137
castbar:SetStatusBarTexture(LSM:Fetch('statusbar', NP.db.statusbar))
138138

139139
NP.StatusBars[castbar] = true

ElvUI/Core/Modules/Nameplates/Elements/ClassPower.lua

+3-3
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ end
7777
function NP:Construct_ClassPower(nameplate)
7878
local containerName = nameplate.frameName..'ClassPower'
7979
local ClassPower = CreateFrame('Frame', containerName, nameplate)
80-
ClassPower:CreateBackdrop('Transparent', nil, nil, nil, nil, true, true)
80+
ClassPower:CreateBackdrop('Transparent', nil, nil, nil, nil, true)
8181
ClassPower:Hide()
8282
ClassPower:SetFrameStrata(nameplate:GetFrameStrata())
8383
ClassPower:SetFrameLevel(5)
@@ -214,7 +214,7 @@ function NP:Construct_Runes(nameplate)
214214
local Runes = CreateFrame('Frame', containerName, nameplate)
215215
Runes:SetFrameStrata(nameplate:GetFrameStrata())
216216
Runes:SetFrameLevel(5)
217-
Runes:CreateBackdrop('Transparent', nil, nil, nil, nil, true, true)
217+
Runes:CreateBackdrop('Transparent', nil, nil, nil, nil, true)
218218
Runes:Hide()
219219

220220
Runes.PostUpdate = NP.Runes_PostUpdate
@@ -295,7 +295,7 @@ function NP:Construct_Stagger(nameplate)
295295
Stagger:SetFrameStrata(nameplate:GetFrameStrata())
296296
Stagger:SetFrameLevel(5)
297297
Stagger:SetStatusBarTexture(LSM:Fetch('statusbar', NP.db.statusbar))
298-
Stagger:CreateBackdrop('Transparent', nil, nil, nil, nil, true, true)
298+
Stagger:CreateBackdrop('Transparent', nil, nil, nil, nil, true)
299299
Stagger:Hide()
300300

301301
NP.StatusBars[Stagger] = true

ElvUI/Core/Modules/Nameplates/Elements/Health.lua

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ function NP:Construct_Health(nameplate)
6464
local Health = CreateFrame('StatusBar', nameplate.frameName..'Health', nameplate)
6565
Health:SetFrameStrata(nameplate:GetFrameStrata())
6666
Health:SetFrameLevel(5)
67-
Health:CreateBackdrop('Transparent', nil, nil, nil, nil, true, true)
67+
Health:CreateBackdrop('Transparent', nil, nil, nil, nil, true)
6868
Health:SetStatusBarTexture(LSM:Fetch('statusbar', NP.db.statusbar))
6969
Health.considerSelectionInCombatHostile = true
7070
Health.UpdateColor = NP.Health_UpdateColor

ElvUI/Core/Modules/Nameplates/Elements/Power.lua

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ function NP:Construct_Power(nameplate)
102102
local Power = CreateFrame('StatusBar', nameplate.frameName..'Power', nameplate)
103103
Power:SetFrameStrata(nameplate:GetFrameStrata())
104104
Power:SetFrameLevel(5)
105-
Power:CreateBackdrop('Transparent', nil, nil, nil, nil, true, true)
105+
Power:CreateBackdrop('Transparent', nil, nil, nil, nil, true)
106106

107107
NP.StatusBars[Power] = true
108108

ElvUI/Mainline/Modules/Skins/Menu.lua

+15-9
Original file line numberDiff line numberDiff line change
@@ -20,23 +20,29 @@ local function SkinFrame(frame)
2020
end
2121
end
2222

23-
local function OpenMenu(manager, region, menuDescription)
23+
function S:SkinMenu(manager, ownerRegion, menuDescription, anchor)
2424
local menu = manager:GetOpenMenu()
25-
if menu then
26-
-- Initial context menu
27-
SkinFrame(menu)
28-
-- SubMenus
29-
menuDescription:AddMenuAcquiredCallback(SkinFrame)
30-
end
25+
if not menu then return end
26+
27+
SkinFrame(menu) -- Initial context menu
28+
menuDescription:AddMenuAcquiredCallback(SkinFrame) -- SubMenus
29+
end
30+
31+
function S:OpenMenu(ownerRegion, menuDescription, anchor)
32+
S:SkinMenu(self, ownerRegion, menuDescription, anchor) -- self is manager (Menu.GetManager)
33+
end
34+
35+
function S:OpenContextMenu(ownerRegion, menuDescription)
36+
S:SkinMenu(self, ownerRegion, menuDescription) -- self is manager (Menu.GetManager)
3137
end
3238

3339
function S:Blizzard_Menu()
3440
if not (E.private.skins.blizzard.enable and E.private.skins.blizzard.misc) then return end
3541

3642
local manager = _G.Menu.GetManager()
3743
if manager then
38-
hooksecurefunc(manager, 'OpenMenu', OpenMenu)
39-
hooksecurefunc(manager, 'OpenContextMenu', OpenMenu)
44+
hooksecurefunc(manager, 'OpenMenu', S.OpenMenu)
45+
hooksecurefunc(manager, 'OpenContextMenu', S.OpenContextMenu)
4046
end
4147
end
4248

0 commit comments

Comments
 (0)