Skip to content

Commit 98e97e0

Browse files
committed
GetValues for Reputation in DataTexts / DataBars
1 parent 9dacbf9 commit 98e97e0

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

ElvUI/Core/Modules/DataBars/Reputation.lua

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,17 @@ local UNKNOWN = UNKNOWN
2929
local QuestRep = 0
3030

3131
local function GetValues(currentStanding, currentReactionThreshold, nextReactionThreshold)
32+
local current = currentStanding - currentReactionThreshold
3233
local maximum = nextReactionThreshold - currentReactionThreshold
33-
local current, diff = currentStanding - currentReactionThreshold, maximum
3434

35-
if diff == 0 then diff = 1 end -- prevent a division by zero
35+
if maximum < 0 then
36+
maximum = current -- account for negative maximum
37+
end
3638

3739
if current == maximum then
3840
return 1, 1, 100, true
3941
else
42+
local diff = (maximum ~= 0 and maximum) or 1 -- prevent a division by zero
4043
return current, maximum, current / diff * 100
4144
end
4245
end

ElvUI/Core/Modules/DataTexts/Reputation.lua

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,17 @@ local STANDING = STANDING
2121
local UNKNOWN = UNKNOWN
2222

2323
local function GetValues(currentStanding, currentReactionThreshold, nextReactionThreshold)
24+
local current = currentStanding - currentReactionThreshold
2425
local maximum = nextReactionThreshold - currentReactionThreshold
25-
local current, diff = currentStanding - currentReactionThreshold, maximum
2626

27-
if diff == 0 then diff = 1 end -- prevent a division by zero
27+
if maximum < 0 then
28+
maximum = current -- account for negative maximum
29+
end
2830

2931
if current == maximum then
3032
return 1, 1, 100, true
3133
else
34+
local diff = (maximum ~= 0 and maximum) or 1 -- prevent a division by zero
3235
return current, maximum, current / diff * 100
3336
end
3437
end

0 commit comments

Comments
 (0)