Merge pull request #106 from Jess-White/feature/412-add-invitations-reinvite-endpoint

Implement invitations reinvite endpoint

Author: Jess-White

app/controllers/api/invitations_controller.rb

@@ -10,8 +10,8 @@ def index
     end
 
     def create
-      invitation_creator = InvitationCreator.new(create_invitation_params, @organization)
-      @invitation = invitation_creator.call!
+      invitation_issuer = InvitationIssuer.new(create_invitation_params, @organization)
+      @invitation = invitation_issuer.call!
       render 'show.json.jb', status: :created
     end
 
@@ -26,6 +26,14 @@ def accept
       }
     end
 
+    def reinvite
+      invitation_email = Invitation.find(params[:id]).email
+      invitation_issuer = InvitationIssuer.new({ email: invitation_email }, @organization)
+      @invitation = invitation_issuer.call!
+
+      render 'show.json.jb'
+    end
+
     private
 
     def create_invitation_params

app/services/invitation_creator.rb renamed to app/services/invitation_issuer.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
-class InvitationCreator
+# Service for issuing a new invitiation or re-inviting an existing invitation if
+# it has expired.
+class InvitationIssuer
   def initialize(invitation_params, organization)
     @invitation_params = invitation_params
     @organization = organization
@@ -12,7 +14,7 @@ def call!
 
     InvitationMailer.with(invitation: invitation).invite.deliver_later
 
-    Rails.logger.info("New invitation #{invitation} created")
+    Rails.logger.info("Invitation #{invitation} issued")
 
     invitation
   end
@@ -25,10 +27,12 @@ def find_or_create_invitation!
     invitation = Invitation.find_by(email: invitation_params[:email], organization_id: organization.id)
     return invitation if invitation.present?
 
-    Invitation.create!(
+    invitation = Invitation.create!(
       **invitation_params,
       organization: organization
     )
+    Rails.logger.info("New invitation #{invitation} created")
+    invitation
   end
 
   def generate_invitation_token!(invitation)

config/routes.rb

@@ -17,7 +17,9 @@
     resources :organizations do
       resources :organization_users, path: :users
       resources :boilerplates
-      resources :invitations
+      resources :invitations do
+        post :reinvite, on: :member
+      end
       resources :categories
       resources :funding_orgs
       resources :grants do

spec/controllers/api/invitations_controller_spec.rb

@@ -161,7 +161,49 @@
   end
 
   describe 'PATCH /organization/:organization_id/invitations/:id/reinvite' do
-    pending "add some examples (or delete) #{__FILE__}"
+    let!(:invitation) { create(:invitation, organization: organization, expires_at: Date.current) }
+
+    context 'when organization does not exist' do
+      it 'renders 401' do
+        post :reinvite, params: {
+          organization_id: 123,
+          id: invitation.id
+        }
+
+        expect(response).to have_http_status(401)
+      end
+    end
+
+    context 'when invitation does not exist' do
+      it 'renders 401' do
+        post :reinvite, params: {
+          organization_id: invitation.organization.id,
+          id: 123
+        }
+
+        expect(response).to have_http_status(401)
+      end
+    end
+
+    context 'when given valid invitation' do
+      it 'renders 200' do
+        post :reinvite, params: {
+          organization_id: invitation.organization.id,
+          id: invitation.id
+        }
+
+        expect(response).to have_http_status(200)
+        expect(JSON.parse(response.body).keys).to contain_exactly(*invitation_fields)
+        expect(JSON.parse(response.body)).to match(
+          a_hash_including(
+            'id' => invitation.id,
+            # Calling reload here since the invitation issuer will update these fields
+            'updated_at' => invitation.reload.updated_at.iso8601(3),
+            'expires_at' => invitation.reload.expires_at.iso8601
+          )
+        )
+      end
+    end
   end
 
   describe 'DELETE /organization/:organization_id/invitations/:id' do

spec/services/invitation_creator_spec.rb

@@ -0,0 +1,79 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+describe InvitationIssuer do
+  let(:organization) { create(:organization) }
+  let(:invitation_params) { { first_name: 'Elenor', last_name: 'Shellstrop', email: '[email protected]' } }
+
+  before do
+    ActiveJob::Base.queue_adapter = :test
+  end
+
+  describe '#call!' do
+    context 'when invitation does not exist' do
+      subject { InvitationIssuer.new(invitation_params, organization) }
+      let!(:result) { subject.call! }
+
+      it 'returns created invitation' do
+        expect(result).to be_instance_of(Invitation)
+        expect(result.first_name).to eq('Elenor')
+      end
+
+      it 'creates an invitation using params' do
+        expect(Invitation.last.first_name).to eq('Elenor')
+      end
+
+      it 'adds invitation to provided organization' do
+        expect(organization.invitations).to include(result)
+      end
+
+      it 'generate a token for the invitation' do
+        expect(Invitation.last.token).to be_instance_of(String)
+      end
+
+      it 'sets expiration date of token to a week from now' do
+        expect(Invitation.last.expires_at).to eq(1.week.from_now.to_date)
+      end
+
+      it 'schedules email to user' do
+        expect { subject.call! }.to have_enqueued_mail(InvitationMailer, :invite)
+      end
+    end
+
+    context 'when invitation already exists' do
+      let!(:existing_invitation) do
+        create(:invitation, organization: organization, email: invitation_params[:email], expires_at: Date.current)
+      end
+
+      subject { InvitationIssuer.new(invitation_params, organization) }
+      let!(:result) { subject.call! }
+
+      it 'returns existing invitation' do
+        expect(result).to eq(existing_invitation)
+      end
+
+      it 'does not create duplicate invitation' do
+        expect(Invitation.count).to eq(1)
+      end
+
+      it 'does not create duplicate invitation association within organization' do
+        expect(organization.invitations).to match_array([result])
+      end
+
+      it 'generate a new token to re-issue the invitation' do
+        expect(result.token).to be_instance_of(String)
+        expect(result.token).not_to eq(existing_invitation.token)
+      end
+
+      it 'sets expiration date of new token to a week from now' do
+        expect(result.expires_at).not_to eq(existing_invitation.expires_at)
+        expect(result.expires_at).to eq(1.week.from_now.to_date)
+      end
+
+      it 'schedules email to user' do
+        expect { subject.call! }.to have_enqueued_mail(InvitationMailer, :invite)
+      end
+    end
+  end
+end