Skip to content

Commit fd9bc28

Browse files
authored
Fix release workflow homebrew PR title check (#4983)
The homebrew PR is created with title 'Steampipe <version>' (no v prefix, using github.event.inputs.version via env.Version). The later check compared against 'Steampipe v<version>' (using env.VERSION which prepends a v). Mismatch caused update_homebrew_tap to always fail after tagging, which then skipped trigger_smoke_tests. Fix: check against github.event.inputs.version to match the PR title convention used across historical homebrew-tap PRs (Steampipe 2.3.5, 2.3.6, 2.4.0, 2.4.1).
1 parent 31a9d9a commit fd9bc28

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/01-steampipe-release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ jobs:
253253
- name: Fail if PR title does not match with version
254254
if: steps.semver_parser.outputs.prerelease == ''
255255
run: |
256-
if [[ "${{ steps.pr_title.outputs.PR_TITLE }}" == "Steampipe ${{ env.VERSION }}" ]]; then
256+
if [[ "${{ steps.pr_title.outputs.PR_TITLE }}" == "Steampipe ${{ github.event.inputs.version }}" ]]; then
257257
echo "Correct version"
258258
else
259259
echo "Incorrect version"

0 commit comments

Comments
 (0)