Non-idempotent stop operations in StopServices

[e-gineer]

Description

While StopServices() has logic to handle when no service is running (returns ServiceNotRunning), the state file removal in the defer at line 169 always attempts os.Remove(). This could cause errors or warnings if called multiple times in quick succession, though the error is currently ignored.

Severity

MEDIUM - Idempotency issue

Test Reference

Test: TestStopServices_Idempotent in pkg/db/db_local/stop_services_test.go:45 (skipped - requires DB)

Suggested Fix

Consider using os.RemoveAll() or checking file existence before removal.

Related Code

• pkg/db/db_local/stop_services.go:163-186

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions]

This issue was closed because it has been stalled for 90 days with no activity.