Skip to content

Commit e2e2b9e

Browse files
authored
Merge branch 'next' into update-upstream
2 parents eee2907 + aa8789b commit e2e2b9e

File tree

110 files changed

+3270
-1530
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

110 files changed

+3270
-1530
lines changed

.github/ISSUE_TEMPLATE.md

+28-19
Original file line numberDiff line numberDiff line change
@@ -24,47 +24,56 @@
2424
You can find webpack docs at https://webpack.js.org/.
2525
-->
2626

27-
28-
### Can you also reproduce the problem with npm 4.x?
27+
### Did you try recovering your dependencies?
2928

3029
<!--
31-
Many errors, especially related to "missing modules", are due to npm bugs.
32-
Which version of npm are you running? You can find out by checking:
33-
34-
npm -v
30+
Your module tree might be corrupted, and that might be causing the issues.
31+
Let's try to recover it. First, delete these files and folders in your project:
3532
36-
If it is 5.x, please be aware that it has more than 50 known bugs, and
37-
is not guaranteed to work with Create React App.
33+
* node_modules
34+
* package-lock.json
35+
* yarn.lock
3836
39-
If it's not starting with 4, try to install npm 4.x:
37+
Then you need to decide which package manager you prefer to use.
38+
We support both npm (https://npmjs.com) and yarn (http://yarnpkg.com/).
39+
However, **they can't be used together in one project** so you need to pick one.
40+
41+
If you decided to use npm, run this in your project directory:
4042
41-
npm install -g npm@4
42-
cd your_project_directory
43-
rm -rf node_modules
44-
npm cache clear
43+
npm install -g npm@latest
4544
npm install
4645
47-
Then try to reproduce the issue again.
48-
Can you still reproduce it?
46+
This should fix your project.
47+
48+
If you decided to use yarn, update it first (https://yarnpkg.com/en/docs/install).
49+
Then run in your project directory:
50+
51+
yarn
52+
53+
This should fix your project.
4954
50-
Note: Please try this even if you are using Yarn so that we know whether it's a Yarn-only bug.
55+
Importantly, **if you decided to use yarn, you should never run `npm install` in the project**.
56+
For example, yarn users should run `yarn add <library>` instead of `npm install <library>`.
57+
Otherwise your project will break again.
58+
59+
Have you done all these steps and still see the issue?
60+
Please paste the output of `npm --version` and/or `yarn --version` to confirm.
5161
-->
5262

5363
(Write your answer here.)
5464

55-
5665
### Which terms did you search for in User Guide?
5766

5867
<!--
5968
There are a few common documented problems, such as watcher not detecting changes, or build failing.
6069
They are described in the Troubleshooting section of the User Guide:
6170
62-
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#troubleshooting
71+
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#troubleshooting
6372
6473
Please scan these few sections for common problems.
6574
Additionally, you can search the User Guide itself for something you're having issues with:
6675
67-
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md
76+
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md
6877
6978
If you didn't find the solution, please share which words you searched for.
7079
This helps us improve documentation for future readers who might encounter the same problem.

.travis.yml

+2
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,13 @@ script:
1515
- 'if [ $TEST_SUITE = "installs" ]; then tasks/e2e-installs.sh; fi'
1616
- 'if [ $TEST_SUITE = "kitchensink" ]; then tasks/e2e-kitchensink.sh; fi'
1717
- 'if [ $TEST_SUITE = "old-node" ]; then tasks/e2e-old-node.sh; fi'
18+
- 'if [ $TEST_SUITE = "monorepos" ]; then tasks/e2e-monorepos.sh; fi'
1819
env:
1920
matrix:
2021
- TEST_SUITE=simple
2122
- TEST_SUITE=installs
2223
- TEST_SUITE=kitchensink
24+
- TEST_SUITE=monorepos
2325
matrix:
2426
include:
2527
- node_js: 0.10

CHANGELOG-0.x.md

+314-314
Large diffs are not rendered by default.

CHANGELOG.md

+405-397
Large diffs are not rendered by default.

CONTRIBUTING.md

+8-8
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Please also provide a **test plan**, i.e. specify how you verified that your add
4343

4444
## Folder Structure of Create React App
4545
`create-react-app` is a monorepo, meaning it is divided into independent sub-packages.<br>
46-
These packages can be found in the [`packages/`](https://github.com/facebookincubator/create-react-app/tree/master/packages) directory.
46+
These packages can be found in the [`packages/`](https://github.com/facebook/create-react-app/tree/master/packages) directory.
4747

4848
### Overview of directory structure
4949
```
@@ -55,25 +55,25 @@ packages/
5555
react-scripts/
5656
```
5757
### Package Descriptions
58-
#### [babel-preset-react-app](https://github.com/facebookincubator/create-react-app/tree/master/packages/babel-preset-react-app)
58+
#### [babel-preset-react-app](https://github.com/facebook/create-react-app/tree/master/packages/babel-preset-react-app)
5959
This package is a babel preset intended to be used with `react-scripts`.<br>
6060
It targets platforms that React is designed to support (IE 9+) and enables experimental features used heavily at Facebook.<br>
6161
This package is enabled by default for all `create-react-app` scaffolded applications.
62-
#### [create-react-app](https://github.com/facebookincubator/create-react-app/tree/master/packages/create-react-app)
62+
#### [create-react-app](https://github.com/facebook/create-react-app/tree/master/packages/create-react-app)
6363
The global CLI command code can be found in this directory, and shouldn't often be changed. It should run on Node 0.10+.
64-
#### [eslint-config-react-app](https://github.com/facebookincubator/create-react-app/tree/master/packages/eslint-config-react-app)
64+
#### [eslint-config-react-app](https://github.com/facebook/create-react-app/tree/master/packages/eslint-config-react-app)
6565
This package contains a conservative set of rules focused on making errors apparent and enforces no style rules.<br>
6666
This package is enabled by default for all `create-react-app` scaffolded applications.
67-
#### [react-dev-utils](https://github.com/facebookincubator/create-react-app/tree/master/packages/react-dev-utils)
67+
#### [react-dev-utils](https://github.com/facebook/create-react-app/tree/master/packages/react-dev-utils)
6868
This package contains utilities used for `react-scripts` and sister packages.<br>
6969
Its main purpose is to conceal code which the user shouldn't be burdened with upon ejecting.
70-
#### [react-scripts](https://github.com/facebookincubator/create-react-app/tree/master/packages/react-scripts)
70+
#### [react-scripts](https://github.com/facebook/create-react-app/tree/master/packages/react-scripts)
7171
This package is the heart of the project, which contains the scripts for setting up the development server, building production builds, configuring all software used, etc.<br>
7272
All functionality must be retained (and configuration given to the user) if they choose to eject.
7373

7474
## Setting Up a Local Copy
7575

76-
1. Clone the repo with `git clone https://github.com/facebookincubator/create-react-app`
76+
1. Clone the repo with `git clone https://github.com/facebook/create-react-app`
7777

7878
2. Run `yarn` in the root `create-react-app` folder.
7979

@@ -111,7 +111,7 @@ By default git would use `CRLF` line endings which would cause the scripts to fa
111111

112112
## Cutting a Release
113113

114-
1. Tag all merged pull requests that go into the release with the relevant milestone. Each merged PR should also be labeled with one of the [labels](https://github.com/facebookincubator/create-react-app/labels) named `tag: ...` to indicate what kind of change it is.
114+
1. Tag all merged pull requests that go into the release with the relevant milestone. Each merged PR should also be labeled with one of the [labels](https://github.com/facebook/create-react-app/labels) named `tag: ...` to indicate what kind of change it is.
115115
2. Close the milestone.
116116
3. In most releases, only `react-scripts` needs to be released. If you don’t have any changes to the `packages/create-react-app` folder, you don’t need to bump its version or publish it (the publish script will publish only changed packages).
117117
4. Note that files in `packages/create-react-app` should be modified with extreme caution. Since it’s a global CLI, any version of `create-react-app` (global CLI) including very old ones should work with the latest version of `react-scripts`.

0 commit comments

Comments
 (0)