Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paywall tabs #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

paywall tabs #6

wants to merge 3 commits into from

Conversation

murtaza52
Copy link

Hi Tim,

I have placed the main tabs and the paywall tabs. These are the problems I am facing -

  1. When in the books tab, the tabs are overlaid by the accounts pane. Can you help with the CSS here?
  2. When in the profile tab, the footer region is overlaying the User Details region. Can you also help with the CSS here?
  3. To activate the tabs, I have placed inline js at two places. When I placed the js in the document.reay it didnt work. So most probably the DOM is being created asynchronously and is not ready when the document.ready function runs.

Can you provide me the content for all the 5 paywall tabs (feature list), and I will put it in. Also will get the CSS right for the paywall internal content.

Thanks,
Murtaza

@twashing
Copy link
Owner

twashing commented Feb 5, 2013

Hey Murtaza,

I tried cloning your latest master (from https://github.com/murtaza52/bkell),
and running it. I get some kind of slingshot exception. That means I can't
login to see or work on the tabs. I just want to confirm that you have this
working locally? Are you getting this error? This was a clean clone to a
new directory (currently refactoring bkell to use compojure / friend).

clj-http: status 400 - (class slingshot.ExceptionInfo) client.clj ::
86clj-http.client/wrap-exceptions client.clj
:: 262 clj-http.client/wrap-accept client.clj ::
273clj-http.client/wrap-accept-encoding client.clj
:: 253 clj-http.client/wrap-content-type client.clj ::
347clj-http.client/wrap-form-params client.clj
:: 369 clj-http.client/wrap-nested-params client.clj ::
332clj-http.client/wrap-method cookies.clj
:: 116 clj-http.cookies/wrap-cookies links.clj ::
50clj-http.links/wrap-links client.clj
:: 384 clj-http.client/wrap-unknown-host client.clj ::
457clj-http.client/post RestFn.java
:: 423 invoke.clojure.lang.RestFn handler.clj ::
169bkell.http.handler/callbackHandlerCommon handler.clj
:: 241 bkell.http.handler :: POST :: /callbackGitkit handler.clj ::
238bkell.http.handler/eval7573

Tim Washington
Interruptsoftware.ca
416.843.9060

"Today a young man on acid realized that all matter is merely energy
condensed to a slow vibration, that we are all one consciousness
experiencing itself subjectively, there is no such thing as death, life is
only a dream, and we are the imagination of ourselves. Here's Tom with the
Weather." -- Bill Hicks

On Mon, Feb 4, 2013 at 6:05 AM, Murtaza Husain [email protected]:

Hi Tim,

I have placed the main tabs and the paywall tabs. These are the problems I
am facing -

When in the books tab, the tabs are overlaid by the accounts pane. Can
you help with the CSS here?
2.

When in the profile tab, the footer region is overlaying the User
Details region. Can you also help with the CSS here?
3.

To activate the tabs, I have placed inline js at two places. When I
placed the js in the document.reay it didnt work. So most probably the DOM
is being created asynchronously and is not ready when the document.ready
function runs.

Can you provide me the content for all the 5 paywall tabs (feature list),
and I will put it in. Also will get the CSS right for the paywall internal
content.

Thanks,

Murtaza

You can merge this Pull Request by running

git pull https://github.com/murtaza52/bkell master

Or view, comment on, or merge it at:

https://github.com/twashing/bkell/pull/6
Commit Summary

  • tabs
  • sub tabs

File Changes

  • M public/css/common.csshttps://github.com/twashing/bkell/pull/6/files#diff-0(27)
  • A public/css/index_backup.csshttps://github.com/twashing/bkell/pull/6/files#diff-1(63)
  • A public/css/jquery-ui-1.10.0.custom.min.csshttps://github.com/twashing/bkell/pull/6/files#diff-2(5)
  • M public/css/landing.csshttps://github.com/twashing/bkell/pull/6/files#diff-3(31)
  • A public/css/select2.csshttps://github.com/twashing/bkell/pull/6/files#diff-4(524)
  • A public/js/lib/jquery-ui-1.10.0.custom.min.jshttps://github.com/twashing/bkell/pull/6/files#diff-5(6)
  • A public/js/lib/jquery1.9.min.jshttps://github.com/twashing/bkell/pull/6/files#diff-6(4)
  • A public/js/lib/select2.min.jshttps://github.com/twashing/bkell/pull/6/files#diff-7(82)
  • M public/landing.htmlhttps://github.com/twashing/bkell/pull/6/files#diff-8(247)
  • M public/templ/haml/account.html.hamlhttps://github.com/twashing/bkell/pull/6/files#diff-9(19)
  • M public/templ/haml/landing.html.hamlhttps://github.com/twashing/bkell/pull/6/files#diff-10(191)
  • M public/templ/sass/common.sasshttps://github.com/twashing/bkell/pull/6/files#diff-11(11)
  • M public/templ/sass/landing.sasshttps://github.com/twashing/bkell/pull/6/files#diff-12(10)

Patch Links:

@murtaza52
Copy link
Author

Hey Tim,

Yes I have it working locally without any problem. And I havent changed any
dependencies.

Try lein2 clean or rm your ~/.m2 dir.

Murtaza

On Tue, Feb 5, 2013 at 11:40 AM, Timothy Washington <
[email protected]> wrote:

Hey Murtaza,

I tried cloning your latest master (from
https://github.com/murtaza52/bkell),
and running it. I get some kind of slingshot exception. That means I can't
login to see or work on the tabs. I just want to confirm that you have this
working locally? Are you getting this error? This was a clean clone to a
new directory (currently refactoring bkell to use compojure / friend).

clj-http: status 400 - (class slingshot.ExceptionInfo) client.clj ::
86clj-http.client/wrap-exceptions client.clj
:: 262 clj-http.client/wrap-accept client.clj ::
273clj-http.client/wrap-accept-encoding client.clj
:: 253 clj-http.client/wrap-content-type client.clj ::
347clj-http.client/wrap-form-params client.clj
:: 369 clj-http.client/wrap-nested-params client.clj ::
332clj-http.client/wrap-method cookies.clj
:: 116 clj-http.cookies/wrap-cookies links.clj ::
50clj-http.links/wrap-links client.clj
:: 384 clj-http.client/wrap-unknown-host client.clj ::
457clj-http.client/post RestFn.java
:: 423 invoke.clojure.lang.RestFn handler.clj ::
169bkell.http.handler/callbackHandlerCommon handler.clj
:: 241 bkell.http.handler :: POST :: /callbackGitkit handler.clj ::
238bkell.http.handler/eval7573

Tim Washington
Interruptsoftware.ca
416.843.9060

"Today a young man on acid realized that all matter is merely energy
condensed to a slow vibration, that we are all one consciousness
experiencing itself subjectively, there is no such thing as death, life is
only a dream, and we are the imagination of ourselves. Here's Tom with the
Weather." -- Bill Hicks

On Mon, Feb 4, 2013 at 6:05 AM, Murtaza Husain <[email protected]

wrote:

Hi Tim,

I have placed the main tabs and the paywall tabs. These are the problems
I
am facing -

When in the books tab, the tabs are overlaid by the accounts pane. Can
you help with the CSS here?
2.

When in the profile tab, the footer region is overlaying the User
Details region. Can you also help with the CSS here?
3.

To activate the tabs, I have placed inline js at two places. When I
placed the js in the document.reay it didnt work. So most probably the
DOM
is being created asynchronously and is not ready when the document.ready
function runs.

Can you provide me the content for all the 5 paywall tabs (feature list),
and I will put it in. Also will get the CSS right for the paywall
internal
content.

Thanks,

Murtaza

You can merge this Pull Request by running

git pull https://github.com/murtaza52/bkell master

Or view, comment on, or merge it at:

https://github.com/twashing/bkell/pull/6
Commit Summary

  • tabs
  • sub tabs

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHubhttps://github.com/twashing/bkell/pull/6#issuecomment-13116028.

@twashing
Copy link
Owner

twashing commented Feb 6, 2013

A) Ok, I'm able to login now. Which is great. Those tabs just need to be
vertical now. And when I go to "books", the tabbing disappears (ie, I can't
go back to profile). But I'm sure you know this and are working on it.

B) *To save time, I'll just give you the test secret key. Absolutely don't
put this in git. We'll just keep it in the local *config.clj .

  • sk_test_mupTKjEiq56MBV7LWIsgBJSq

C) If you look at the "Bkeeping-Paywall-Deliverables" document I sent
you, it has the text / copy needed for each tab (trial has the same
content as basic). So there's that. Ans obviously, you'll need to fill in
the remaining credit card input fields. But you're probably already working
on that.

Ok, thanks Murtaza, and talk soon.
Tim

@murtaza52
Copy link
Author

Hey is this conversation from the pull request, then the key will be saved
in the history on github.

I will give another stab on getting the tabs vertical. The tabs disappear
because maybe the css is hard coded for the accounts pane, so it overlaps
the tab elements. Can you help here ?

Thanks,
Murtaza

On Wed, Feb 6, 2013 at 9:31 PM, Timothy Washington <[email protected]

wrote:

A) Ok, I'm able to login now. Which is great. Those tabs just need to be
vertical now. And when I go to "books", the tabbing disappears (ie, I can't
go back to profile). But I'm sure you know this and are working on it.

B) *To save time, I'll just give you the test secret key. Absolutely don't
put this in git. We'll just keep it in the local *config.clj .

  • sk_test_mupTKjEiq56MBV7LWIsgBJSq

C) If you look at the "Bkeeping-Paywall-Deliverables" document I sent
you, it has the text / copy needed for each tab (trial has the same
content as basic). So there's that. Ans obviously, you'll need to fill in
the remaining credit card input fields. But you're probably already working
on that.

Ok, thanks Murtaza, and talk soon.
Tim

—
Reply to this email directly or view it on GitHubhttps://github.com/twashing/bkell/pull/6#issuecomment-13188909.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murtaza52 @twashing @murtaza-husain