-
Notifications
You must be signed in to change notification settings - Fork 214
Officially support Chromium's new documentPictureInPicture API #2044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@donaltoomey is there any update here? |
@jpodwys we have a work in progress PR for this feature. Can you please have a look and see if it addresses your needs? TIA! https://github.com/twilio/twilio-video.js/pull/2093/files |
Thank you for working on this! |
This is now supported in 2.31.0 |
Sorry for the delay - I was able to get this prioritized. Unfortunately, the latest release (2.31.0) still permanently pauses video tracks after backgrounding the browser tab that spawned the PiP window. Here's a screen recording showing this behavior. Please let me know if you have any questions. TwilioDemoFast480p.mov |
Thank you for trying it out @jpodwys . Can you provide me access to the app that reproduces the issue? Also, are you able to reproduce it using our quickstart? https://github.com/twilio/video-quickstart-js/ |
Thank you for the fast response! TwilioDemoAppRepro480p.mov |
Thanks @jpodwys . We'll take a look at it more. |
Thank you! |
Can we please reopen this issue? |
Twilio employee Donal Toomey requested that I create this issue.
I'd like to request official documentPictureInPicture support. Today, Twilio's very nice efficiency features (pausing tracks when a tab is backgrounded) result in pausing all video feeds in a documentPictureInPicture context. I've forked Twilio's SDK to support this. Would love to see official support so we can get back onto the main repo.
I'm also happy to share the changes I made, although they were more brute force than surgical.
Thank you!
The text was updated successfully, but these errors were encountered: