Skip to content

Officially support Chromium's new documentPictureInPicture API #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpodwys opened this issue Mar 11, 2024 · 10 comments
Open

Officially support Chromium's new documentPictureInPicture API #2044

jpodwys opened this issue Mar 11, 2024 · 10 comments
Assignees

Comments

@jpodwys
Copy link

jpodwys commented Mar 11, 2024

Twilio employee Donal Toomey requested that I create this issue.

I'd like to request official documentPictureInPicture support. Today, Twilio's very nice efficiency features (pausing tracks when a tab is backgrounded) result in pausing all video feeds in a documentPictureInPicture context. I've forked Twilio's SDK to support this. Would love to see official support so we can get back onto the main repo.

I'm also happy to share the changes I made, although they were more brute force than surgical.

Thank you!

@jpodwys
Copy link
Author

jpodwys commented Jun 26, 2024

@donaltoomey is there any update here?

@charliesantos charliesantos self-assigned this Mar 6, 2025
@charliesantos
Copy link
Collaborator

@jpodwys we have a work in progress PR for this feature. Can you please have a look and see if it addresses your needs? TIA! https://github.com/twilio/twilio-video.js/pull/2093/files

@jpodwys
Copy link
Author

jpodwys commented Apr 8, 2025

Thank you for working on this!
I'll need to get work to approve some time for me to pull this branch, build it, and test it locally.

@charliesantos
Copy link
Collaborator

This is now supported in 2.31.0

@jpodwys
Copy link
Author

jpodwys commented May 22, 2025

Sorry for the delay - I was able to get this prioritized. Unfortunately, the latest release (2.31.0) still permanently pauses video tracks after backgrounding the browser tab that spawned the PiP window. Here's a screen recording showing this behavior. Please let me know if you have any questions.

TwilioDemoFast480p.mov

@charliesantos
Copy link
Collaborator

Thank you for trying it out @jpodwys . Can you provide me access to the app that reproduces the issue? Also, are you able to reproduce it using our quickstart? https://github.com/twilio/video-quickstart-js/

@jpodwys
Copy link
Author

jpodwys commented May 22, 2025

Thank you for the fast response!
Yes, I'm able to reproduce this using Twilio's quickstart application. Here's a screen recording

TwilioDemoAppRepro480p.mov

@charliesantos
Copy link
Collaborator

Thanks @jpodwys . We'll take a look at it more.

@jpodwys
Copy link
Author

jpodwys commented May 22, 2025

Thank you!

@jpodwys
Copy link
Author

jpodwys commented May 23, 2025

Can we please reopen this issue?

@charliesantos charliesantos reopened this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants