From 7cd41285c281b19610cf113c9575341bced190e9 Mon Sep 17 00:00:00 2001 From: James Burton Date: Fri, 28 Jan 2022 14:04:12 -0500 Subject: [PATCH 1/3] Add 10s timeout to requests.get so that the scraper doesn't hang. --- scraper/downloaders.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scraper/downloaders.py b/scraper/downloaders.py index 9326f36..abd2751 100644 --- a/scraper/downloaders.py +++ b/scraper/downloaders.py @@ -28,8 +28,8 @@ class RequestsDownloader(Downloader): """ @staticmethod def download(url): - result = requests.get(url) - + result = requests.get(url,timeout=10) + if result.status_code != 200: raise Exception("Received non-200 response.") From 29788823d7df4123c4f7a630b5e092a2f1c2ff45 Mon Sep 17 00:00:00 2001 From: James Burton Date: Fri, 28 Jan 2022 14:39:51 -0500 Subject: [PATCH 2/3] Change corrected and uncorrectables graph to show change in values instead of totals. --- full-service/grafana_dashboards/default.json | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/full-service/grafana_dashboards/default.json b/full-service/grafana_dashboards/default.json index bb1abcb..0edf7f8 100644 --- a/full-service/grafana_dashboards/default.json +++ b/full-service/grafana_dashboards/default.json @@ -495,7 +495,11 @@ }, { "params": [], - "type": "mean" + "type": "last" + }, + { + "params": [], + "type": "non_negative_difference" } ] ], @@ -630,7 +634,11 @@ }, { "params": [], - "type": "mean" + "type": "last" + }, + { + "params": [], + "type": "non_negative_difference" } ] ], @@ -898,4 +906,4 @@ "title": "Modem", "uid": "KRgNDKwMz", "version": 11 -} \ No newline at end of file +} From 571f01371cf4810b78dc2f2967739210ed8a9bac Mon Sep 17 00:00:00 2001 From: James Burton Date: Fri, 28 Jan 2022 15:22:18 -0500 Subject: [PATCH 3/3] Set minimum y-axis to 0 for corrected and uncorrectables graph because these can never be negative. --- full-service/grafana_dashboards/default.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/full-service/grafana_dashboards/default.json b/full-service/grafana_dashboards/default.json index 0edf7f8..b17ab28 100644 --- a/full-service/grafana_dashboards/default.json +++ b/full-service/grafana_dashboards/default.json @@ -530,7 +530,7 @@ "label": null, "logBase": 1, "max": null, - "min": null, + "min": "0", "show": true }, { @@ -669,7 +669,7 @@ "label": null, "logBase": 1, "max": null, - "min": null, + "min": "0", "show": true }, {