feat: updated logic to now consider mentions while filtering #403
+41
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #242
Implements the missing
mentionsfield filtering in thelogsSubscribe/logsUnsubscribeWebSocket functionality.notify_logs_subscribersmethodAll,AllWithVotes, andMentions(Vec<String>)filterscontinuewhen commitment level doesn't matchNext Steps: Tests covering different behaviors of this feature.
Feedback is very much welcomed. Happy to iterate on the approach before investing time in tests.