Skip to content

Commit 7da99ae

Browse files
authored
improvement(routerlicious-driver): change Object.keys to Object.entries (microsoft#23710)
Prepare for enabling no-unchecked-record-access / noUncheckedIndexedAccess in routerlicious-driver by switching Object.keys to Object.entries. Full type safety will require additional changes in a future PR.
1 parent 701bbd5 commit 7da99ae

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

packages/drivers/routerlicious-driver/src/createNewUtils.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,7 @@ import { ISummaryTree, SummaryType } from "@fluidframework/driver-definitions";
1212
* @returns Modified summary tree where the blob contents could be utf8 string only.
1313
*/
1414
export function convertSummaryToCreateNewSummary(summary: ISummaryTree): ISummaryTree {
15-
const keys = Object.keys(summary.tree);
16-
for (const key of keys) {
17-
const summaryObject = summary.tree[key];
18-
15+
for (const [key, summaryObject] of Object.entries(summary.tree)) {
1916
switch (summaryObject.type) {
2017
case SummaryType.Tree: {
2118
summary.tree[key] = convertSummaryToCreateNewSummary(summaryObject);

packages/drivers/routerlicious-driver/src/summaryTreeUploadManager.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ export class SummaryTreeUploadManager implements ISummaryUploadManager {
4141
previousFullSnapshot: ISnapshotTreeEx | undefined,
4242
): Promise<string> {
4343
const entries = await Promise.all(
44-
Object.keys(summaryTree.tree).map(async (key) => {
45-
const entry = summaryTree.tree[key];
44+
Object.entries(summaryTree.tree).map(async ([key, entry]) => {
4645
const pathHandle = await this.writeSummaryTreeObject(entry, previousFullSnapshot);
4746
const treeEntry: IGitCreateTreeEntry = {
4847
mode: getGitMode(entry),

0 commit comments

Comments
 (0)