Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glint-expect-error/ignore directive handling needs to be applied to run-tsc as well #797

Open
machty opened this issue Feb 3, 2025 · 0 comments

Comments

@machty
Copy link
Contributor

machty commented Feb 3, 2025

We fixed a number of issues blocking glint-expect-error in #795, but our "hook point" is specific to the Language Server, and not TSC, meaning if you run glint executable for type-checking purposes, the glint-expect-error directives won't kick in and you'll get errors for guarded lines.

Currently investigating how to accomplish this, but it seems solving this properly will also solve it for TS Plugin mode, which I think is also disconnected from the Language Server support we have right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant