Skip to content

Commit 1d48bc9

Browse files
armanbilgearmanbilge
authored
Merge pull request #4204 from armanbilge/issue/3719
Remove unnecessary MiMa filters
2 parents e25fb7d + c05afeb commit 1d48bc9

File tree

1 file changed

+85
-103
lines changed

1 file changed

+85
-103
lines changed

‎mima.sbt

Lines changed: 85 additions & 103 deletions
Original file line numberDiff line numberDiff line change
@@ -2,104 +2,91 @@ import com.typesafe.tools.mima.core.ProblemFilters._
22
import com.typesafe.tools.mima.core._
33

44
ThisBuild / mimaBinaryIssueFilters ++= {
5-
// Only sealed abstract classes that provide implicit instances to companion objects are allowed here, since they don't affect usage outside of the file.
5+
// These things are Ops classes that shouldn't have the `value` exposed. These should have never been public because they don't
6+
// provide any value. Making them private because of issues like #2514 and #2613.
67
Seq(
7-
exclude[DirectMissingMethodProblem]("cats.data.OptionTInstances2.catsDataTraverseForOptionT"),
8-
exclude[DirectMissingMethodProblem]("cats.data.KleisliInstances1.catsDataCommutativeArrowForKleisliId"),
9-
exclude[DirectMissingMethodProblem]("cats.data.OptionTInstances1.catsDataMonoidKForOptionT"),
10-
exclude[DirectMissingMethodProblem]("cats.data.OptionTInstances0.catsDataMonoidForOptionT"),
11-
exclude[DirectMissingMethodProblem]("cats.data.KleisliInstances0.catsDataMonadForKleisliId"),
12-
exclude[DirectMissingMethodProblem]("cats.data.KleisliInstances1.catsDataCommutativeArrowForKleisli"),
13-
exclude[DirectMissingMethodProblem]("cats.data.KleisliInstances4.catsDataCommutativeFlatMapForKleisli"),
14-
exclude[DirectMissingMethodProblem]("cats.data.IRWSTInstances1.catsDataStrongForIRWST"),
15-
exclude[DirectMissingMethodProblem]("cats.data.OptionTInstances1.catsDataMonadErrorMonadForOptionT"),
16-
exclude[DirectMissingMethodProblem]("cats.data.OptionTInstances1.catsDataMonadErrorForOptionT")
17-
) ++
18-
// These things are Ops classes that shouldn't have the `value` exposed. These should have never been public because they don't
19-
// provide any value. Making them private because of issues like #2514 and #2613.
20-
Seq(
21-
exclude[DirectMissingMethodProblem]("cats.ApplicativeError#LiftFromOptionPartially.dummy"),
22-
exclude[DirectMissingMethodProblem]("cats.data.Const#OfPartiallyApplied.dummy"),
23-
exclude[DirectMissingMethodProblem]("cats.data.EitherT#CondPartiallyApplied.dummy"),
24-
exclude[DirectMissingMethodProblem]("cats.data.EitherT#FromEitherPartiallyApplied.dummy"),
25-
exclude[DirectMissingMethodProblem]("cats.data.EitherT#FromOptionPartiallyApplied.dummy"),
26-
exclude[DirectMissingMethodProblem]("cats.data.EitherT#LeftPartiallyApplied.dummy"),
27-
exclude[DirectMissingMethodProblem]("cats.data.EitherT#LeftTPartiallyApplied.dummy"),
28-
exclude[DirectMissingMethodProblem]("cats.data.EitherT#PurePartiallyApplied.dummy"),
29-
exclude[DirectMissingMethodProblem]("cats.data.EitherT#RightPartiallyApplied.dummy"),
30-
exclude[DirectMissingMethodProblem]("cats.data.IorT#BothTPartiallyApplied.dummy"),
31-
exclude[DirectMissingMethodProblem]("cats.data.IorT#CondPartiallyApplied.dummy"),
32-
exclude[DirectMissingMethodProblem]("cats.data.IorT#FromEitherPartiallyApplied.dummy"),
33-
exclude[DirectMissingMethodProblem]("cats.data.IorT#FromIorPartiallyApplied.dummy"),
34-
exclude[DirectMissingMethodProblem]("cats.data.IorT#FromOptionPartiallyApplied.dummy"),
35-
exclude[DirectMissingMethodProblem]("cats.data.IorT#LeftPartiallyApplied.dummy"),
36-
exclude[DirectMissingMethodProblem]("cats.data.IorT#LeftTPartiallyApplied.dummy"),
37-
exclude[DirectMissingMethodProblem]("cats.data.IorT#PurePartiallyApplied.dummy"),
38-
exclude[DirectMissingMethodProblem]("cats.data.IorT#RightPartiallyApplied.dummy"),
39-
exclude[DirectMissingMethodProblem]("cats.data.NonEmptyChainOps.value"),
40-
exclude[DirectMissingMethodProblem]("cats.data.OptionT#FromOptionPartiallyApplied.dummy"),
41-
exclude[DirectMissingMethodProblem]("cats.data.OptionT#PurePartiallyApplied.dummy"),
42-
exclude[DirectMissingMethodProblem]("cats.data.Validated#CatchOnlyPartiallyApplied.dummy"),
43-
exclude[DirectMissingMethodProblem]("cats.free.Free#FreeInjectKPartiallyApplied.dummy"),
44-
exclude[DirectMissingMethodProblem]("cats.free.Free#FreeLiftInjectKPartiallyApplied.dummy"),
45-
exclude[DirectMissingMethodProblem]("cats.free.FreeT#FreeTLiftInjectKPartiallyApplied.dummy"),
46-
exclude[DirectMissingMethodProblem]("cats.syntax.ApplicativeErrorIdOps.e"),
47-
exclude[DirectMissingMethodProblem]("cats.syntax.ApplicativeErrorOps.fa"),
48-
exclude[DirectMissingMethodProblem]("cats.syntax.ApplicativeIdOps.a"),
49-
exclude[DirectMissingMethodProblem]("cats.syntax.ApplicativeOps.fa"),
50-
exclude[DirectMissingMethodProblem]("cats.syntax.ApplyOps.fa"),
51-
exclude[DirectMissingMethodProblem]("cats.syntax.BinestedIdOps.value"),
52-
exclude[DirectMissingMethodProblem]("cats.syntax.BitraverseOps.fab"),
53-
exclude[DirectMissingMethodProblem]("cats.syntax.DistributiveOps.fa"),
54-
exclude[DirectMissingMethodProblem]("cats.syntax.EitherIdOps.obj"),
55-
exclude[DirectMissingMethodProblem]("cats.syntax.EitherIdOpsBinCompat0.value"),
56-
exclude[DirectMissingMethodProblem]("cats.syntax.EitherSyntax#CatchOnlyPartiallyApplied.dummy"),
57-
exclude[DirectMissingMethodProblem]("cats.syntax.EitherKOps.fa"),
58-
exclude[DirectMissingMethodProblem]("cats.syntax.EitherObjectOps.either"),
59-
exclude[DirectMissingMethodProblem]("cats.syntax.EitherOps.eab"),
60-
exclude[DirectMissingMethodProblem]("cats.syntax.EitherOpsBinCompat0.value"),
61-
exclude[DirectMissingMethodProblem]("cats.syntax.FlatMapIdOps.a"),
62-
exclude[DirectMissingMethodProblem]("cats.syntax.FlatMapOps.fa"),
63-
exclude[DirectMissingMethodProblem]("cats.syntax.FlatMapOptionOps.fopta"),
64-
exclude[DirectMissingMethodProblem]("cats.syntax.FlattenOps.ffa"),
65-
exclude[DirectMissingMethodProblem]("cats.syntax.FoldableOps.fa"),
66-
exclude[DirectMissingMethodProblem]("cats.syntax.GuardOps.condition"),
67-
exclude[DirectMissingMethodProblem]("cats.syntax.IfMOps.fa"),
68-
exclude[DirectMissingMethodProblem]("cats.syntax.IndexOps.fa"),
69-
exclude[DirectMissingMethodProblem]("cats.syntax.IorIdOps.a"),
70-
exclude[DirectMissingMethodProblem]("cats.syntax.LeftOps.left"),
71-
exclude[DirectMissingMethodProblem]("cats.syntax.ListOps.la"),
72-
exclude[DirectMissingMethodProblem]("cats.syntax.ListOpsBinCompat0.la"),
73-
exclude[DirectMissingMethodProblem]("cats.syntax.MonadErrorOps.fa"),
74-
exclude[DirectMissingMethodProblem]("cats.syntax.MonadErrorRethrowOps.fea"),
75-
exclude[DirectMissingMethodProblem]("cats.syntax.MonadIdOps.a"),
76-
exclude[DirectMissingMethodProblem]("cats.syntax.MonadOps.fa"),
77-
exclude[DirectMissingMethodProblem]("cats.syntax.MonoidOps.lhs"),
78-
exclude[DirectMissingMethodProblem]("cats.syntax.NestedBitraverseOps.fgagb"),
79-
exclude[DirectMissingMethodProblem]("cats.syntax.NestedFoldableOps.fga"),
80-
exclude[DirectMissingMethodProblem]("cats.syntax.NestedIdOps.value"),
81-
exclude[DirectMissingMethodProblem]("cats.syntax.NestedReducibleOps.fga"),
82-
exclude[DirectMissingMethodProblem]("cats.syntax.OptionIdOps.a"),
83-
exclude[DirectMissingMethodProblem]("cats.syntax.OptionOps.oa"),
84-
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelApOps.ma"),
85-
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelFlatSequenceOps.tmta"),
86-
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelFlatTraversableOps.ta"),
87-
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelSequence_Ops.tma"),
88-
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelSequenceOps.tma"),
89-
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelTraversable_Ops.ta"),
90-
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelTraversableOps.ta"),
91-
exclude[DirectMissingMethodProblem]("cats.syntax.RightOps.right"),
92-
exclude[DirectMissingMethodProblem]("cats.syntax.SeparateOps.fgab"),
93-
exclude[DirectMissingMethodProblem]("cats.syntax.SetOps.se"),
94-
exclude[DirectMissingMethodProblem]("cats.syntax.TabulateOps.f"),
95-
exclude[DirectMissingMethodProblem]("cats.syntax.TryOps.self"),
96-
exclude[DirectMissingMethodProblem]("cats.syntax.UniteOps.fga"),
97-
exclude[DirectMissingMethodProblem]("cats.syntax.ValidatedExtension.self"),
98-
exclude[DirectMissingMethodProblem]("cats.syntax.ValidatedIdOpsBinCompat0.a"),
99-
exclude[DirectMissingMethodProblem]("cats.syntax.ValidatedIdSyntax.a"),
100-
exclude[DirectMissingMethodProblem]("cats.syntax.VectorOps.va"),
101-
exclude[DirectMissingMethodProblem]("cats.syntax.WriterIdSyntax.a")
102-
) ++ // Only compile-time abstractions (macros) allowed here
8+
exclude[DirectMissingMethodProblem]("cats.ApplicativeError#LiftFromOptionPartially.dummy"),
9+
exclude[DirectMissingMethodProblem]("cats.data.Const#OfPartiallyApplied.dummy"),
10+
exclude[DirectMissingMethodProblem]("cats.data.EitherT#CondPartiallyApplied.dummy"),
11+
exclude[DirectMissingMethodProblem]("cats.data.EitherT#FromEitherPartiallyApplied.dummy"),
12+
exclude[DirectMissingMethodProblem]("cats.data.EitherT#FromOptionPartiallyApplied.dummy"),
13+
exclude[DirectMissingMethodProblem]("cats.data.EitherT#LeftPartiallyApplied.dummy"),
14+
exclude[DirectMissingMethodProblem]("cats.data.EitherT#LeftTPartiallyApplied.dummy"),
15+
exclude[DirectMissingMethodProblem]("cats.data.EitherT#PurePartiallyApplied.dummy"),
16+
exclude[DirectMissingMethodProblem]("cats.data.EitherT#RightPartiallyApplied.dummy"),
17+
exclude[DirectMissingMethodProblem]("cats.data.IorT#BothTPartiallyApplied.dummy"),
18+
exclude[DirectMissingMethodProblem]("cats.data.IorT#CondPartiallyApplied.dummy"),
19+
exclude[DirectMissingMethodProblem]("cats.data.IorT#FromEitherPartiallyApplied.dummy"),
20+
exclude[DirectMissingMethodProblem]("cats.data.IorT#FromIorPartiallyApplied.dummy"),
21+
exclude[DirectMissingMethodProblem]("cats.data.IorT#FromOptionPartiallyApplied.dummy"),
22+
exclude[DirectMissingMethodProblem]("cats.data.IorT#LeftPartiallyApplied.dummy"),
23+
exclude[DirectMissingMethodProblem]("cats.data.IorT#LeftTPartiallyApplied.dummy"),
24+
exclude[DirectMissingMethodProblem]("cats.data.IorT#PurePartiallyApplied.dummy"),
25+
exclude[DirectMissingMethodProblem]("cats.data.IorT#RightPartiallyApplied.dummy"),
26+
exclude[DirectMissingMethodProblem]("cats.data.NonEmptyChainOps.value"),
27+
exclude[DirectMissingMethodProblem]("cats.data.OptionT#FromOptionPartiallyApplied.dummy"),
28+
exclude[DirectMissingMethodProblem]("cats.data.OptionT#PurePartiallyApplied.dummy"),
29+
exclude[DirectMissingMethodProblem]("cats.data.Validated#CatchOnlyPartiallyApplied.dummy"),
30+
exclude[DirectMissingMethodProblem]("cats.free.Free#FreeInjectKPartiallyApplied.dummy"),
31+
exclude[DirectMissingMethodProblem]("cats.free.Free#FreeLiftInjectKPartiallyApplied.dummy"),
32+
exclude[DirectMissingMethodProblem]("cats.free.FreeT#FreeTLiftInjectKPartiallyApplied.dummy"),
33+
exclude[DirectMissingMethodProblem]("cats.syntax.ApplicativeErrorIdOps.e"),
34+
exclude[DirectMissingMethodProblem]("cats.syntax.ApplicativeErrorOps.fa"),
35+
exclude[DirectMissingMethodProblem]("cats.syntax.ApplicativeIdOps.a"),
36+
exclude[DirectMissingMethodProblem]("cats.syntax.ApplicativeOps.fa"),
37+
exclude[DirectMissingMethodProblem]("cats.syntax.ApplyOps.fa"),
38+
exclude[DirectMissingMethodProblem]("cats.syntax.BinestedIdOps.value"),
39+
exclude[DirectMissingMethodProblem]("cats.syntax.BitraverseOps.fab"),
40+
exclude[DirectMissingMethodProblem]("cats.syntax.DistributiveOps.fa"),
41+
exclude[DirectMissingMethodProblem]("cats.syntax.EitherIdOps.obj"),
42+
exclude[DirectMissingMethodProblem]("cats.syntax.EitherIdOpsBinCompat0.value"),
43+
exclude[DirectMissingMethodProblem]("cats.syntax.EitherSyntax#CatchOnlyPartiallyApplied.dummy"),
44+
exclude[DirectMissingMethodProblem]("cats.syntax.EitherKOps.fa"),
45+
exclude[DirectMissingMethodProblem]("cats.syntax.EitherObjectOps.either"),
46+
exclude[DirectMissingMethodProblem]("cats.syntax.EitherOps.eab"),
47+
exclude[DirectMissingMethodProblem]("cats.syntax.EitherOpsBinCompat0.value"),
48+
exclude[DirectMissingMethodProblem]("cats.syntax.FlatMapIdOps.a"),
49+
exclude[DirectMissingMethodProblem]("cats.syntax.FlatMapOps.fa"),
50+
exclude[DirectMissingMethodProblem]("cats.syntax.FlatMapOptionOps.fopta"),
51+
exclude[DirectMissingMethodProblem]("cats.syntax.FlattenOps.ffa"),
52+
exclude[DirectMissingMethodProblem]("cats.syntax.FoldableOps.fa"),
53+
exclude[DirectMissingMethodProblem]("cats.syntax.GuardOps.condition"),
54+
exclude[DirectMissingMethodProblem]("cats.syntax.IfMOps.fa"),
55+
exclude[DirectMissingMethodProblem]("cats.syntax.IndexOps.fa"),
56+
exclude[DirectMissingMethodProblem]("cats.syntax.IorIdOps.a"),
57+
exclude[DirectMissingMethodProblem]("cats.syntax.LeftOps.left"),
58+
exclude[DirectMissingMethodProblem]("cats.syntax.ListOps.la"),
59+
exclude[DirectMissingMethodProblem]("cats.syntax.ListOpsBinCompat0.la"),
60+
exclude[DirectMissingMethodProblem]("cats.syntax.MonadErrorOps.fa"),
61+
exclude[DirectMissingMethodProblem]("cats.syntax.MonadErrorRethrowOps.fea"),
62+
exclude[DirectMissingMethodProblem]("cats.syntax.MonadIdOps.a"),
63+
exclude[DirectMissingMethodProblem]("cats.syntax.MonadOps.fa"),
64+
exclude[DirectMissingMethodProblem]("cats.syntax.MonoidOps.lhs"),
65+
exclude[DirectMissingMethodProblem]("cats.syntax.NestedBitraverseOps.fgagb"),
66+
exclude[DirectMissingMethodProblem]("cats.syntax.NestedFoldableOps.fga"),
67+
exclude[DirectMissingMethodProblem]("cats.syntax.NestedIdOps.value"),
68+
exclude[DirectMissingMethodProblem]("cats.syntax.NestedReducibleOps.fga"),
69+
exclude[DirectMissingMethodProblem]("cats.syntax.OptionIdOps.a"),
70+
exclude[DirectMissingMethodProblem]("cats.syntax.OptionOps.oa"),
71+
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelApOps.ma"),
72+
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelFlatSequenceOps.tmta"),
73+
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelFlatTraversableOps.ta"),
74+
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelSequence_Ops.tma"),
75+
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelSequenceOps.tma"),
76+
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelTraversable_Ops.ta"),
77+
exclude[DirectMissingMethodProblem]("cats.syntax.ParallelTraversableOps.ta"),
78+
exclude[DirectMissingMethodProblem]("cats.syntax.RightOps.right"),
79+
exclude[DirectMissingMethodProblem]("cats.syntax.SeparateOps.fgab"),
80+
exclude[DirectMissingMethodProblem]("cats.syntax.SetOps.se"),
81+
exclude[DirectMissingMethodProblem]("cats.syntax.TabulateOps.f"),
82+
exclude[DirectMissingMethodProblem]("cats.syntax.TryOps.self"),
83+
exclude[DirectMissingMethodProblem]("cats.syntax.UniteOps.fga"),
84+
exclude[DirectMissingMethodProblem]("cats.syntax.ValidatedExtension.self"),
85+
exclude[DirectMissingMethodProblem]("cats.syntax.ValidatedIdOpsBinCompat0.a"),
86+
exclude[DirectMissingMethodProblem]("cats.syntax.ValidatedIdSyntax.a"),
87+
exclude[DirectMissingMethodProblem]("cats.syntax.VectorOps.va"),
88+
exclude[DirectMissingMethodProblem]("cats.syntax.WriterIdSyntax.a")
89+
) ++ // Only compile-time abstractions (macros) allowed here
10390
Seq(
10491
exclude[IncompatibleMethTypeProblem]("cats.arrow.FunctionKMacros.lift"),
10592
exclude[MissingTypesProblem]("cats.arrow.FunctionKMacros$"),
@@ -113,18 +100,13 @@ ThisBuild / mimaBinaryIssueFilters ++= {
113100
exclude[MissingClassProblem](
114101
"cats.kernel.compat.scalaVersionMoreSpecific$suppressUnusedImportWarningForScalaVersionMoreSpecific"
115102
)
116-
) ++ // Only narrowing of types allowed here
117-
Seq(
118-
exclude[IncompatibleSignatureProblem]("*")
119103
) ++ // New issues found since mima 0.8.0 (#3596, #3641)
120104
Seq(
121105
exclude[NewMixinForwarderProblem]("cats.kernel.Band#mcI#sp.combineN"),
122106
exclude[NewMixinForwarderProblem]("cats.kernel.Band#mcD#sp.combineN"),
123107
exclude[NewMixinForwarderProblem]("cats.kernel.Band#mcJ#sp.combineN"),
124108
exclude[NewMixinForwarderProblem]("cats.kernel.Band.combineN"),
125-
exclude[NewMixinForwarderProblem]("cats.kernel.Band#mcF#sp.combineN"),
126-
exclude[NewMixinForwarderProblem]("cats.data.Tuple2KApply.product"),
127-
exclude[NewMixinForwarderProblem]("cats.InvariantInstances0.catsApplicativeForArrow")
109+
exclude[NewMixinForwarderProblem]("cats.kernel.Band#mcF#sp.combineN")
128110
) ++ // Additional methods in package-private traits
129111
Seq(
130112
exclude[ReversedMissingMethodProblem]("cats.data.NonEmptyCollection.grouped")

0 commit comments

Comments
 (0)