Skip to content

Commit 4ecb496

Browse files
Allow null candidate in RTCPeerConnection.addIceCandidate (microsoft#1739)
Co-authored-by: saschanaz <[email protected]>
1 parent 21ecb34 commit 4ecb496

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

Diff for: baselines/dom.generated.d.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -18158,9 +18158,9 @@ interface RTCPeerConnection extends EventTarget {
1815818158
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCPeerConnection/signalingState) */
1815918159
readonly signalingState: RTCSignalingState;
1816018160
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCPeerConnection/addIceCandidate) */
18161-
addIceCandidate(candidate?: RTCIceCandidateInit): Promise<void>;
18161+
addIceCandidate(candidate?: RTCIceCandidateInit | null): Promise<void>;
1816218162
/** @deprecated */
18163-
addIceCandidate(candidate: RTCIceCandidateInit, successCallback: VoidFunction, failureCallback: RTCPeerConnectionErrorCallback): Promise<void>;
18163+
addIceCandidate(candidate: RTCIceCandidateInit | null, successCallback: VoidFunction, failureCallback: RTCPeerConnectionErrorCallback): Promise<void>;
1816418164
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCPeerConnection/addTrack) */
1816518165
addTrack(track: MediaStreamTrack, ...streams: MediaStream[]): RTCRtpSender;
1816618166
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCPeerConnection/addTransceiver) */

Diff for: inputfiles/overridingTypes.jsonc

+14
Original file line numberDiff line numberDiff line change
@@ -2169,7 +2169,21 @@
21692169
"method": {
21702170
"addIceCandidate": {
21712171
"signature": {
2172+
"0": {
2173+
"param": [
2174+
{
2175+
"name": "candidate",
2176+
"nullable": true
2177+
}
2178+
]
2179+
},
21722180
"1": {
2181+
"param": [
2182+
{
2183+
"name": "candidate",
2184+
"nullable": true
2185+
}
2186+
],
21732187
"deprecated": true
21742188
}
21752189
}

0 commit comments

Comments
 (0)