Skip to content

Commit 99ce5eb

Browse files
authored
Restore StartViewTransitionOptions (microsoft#1918)
Co-authored-by: saschanaz <[email protected]>
1 parent c92d213 commit 99ce5eb

File tree

3 files changed

+12
-15
lines changed

3 files changed

+12
-15
lines changed

baselines/dom.generated.d.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -2090,6 +2090,11 @@ interface SpeechSynthesisEventInit extends EventInit {
20902090
utterance: SpeechSynthesisUtterance;
20912091
}
20922092

2093+
interface StartViewTransitionOptions {
2094+
types?: string[] | null;
2095+
update?: ViewTransitionUpdateCallback | null;
2096+
}
2097+
20932098
interface StaticRangeInit {
20942099
endContainer: Node;
20952100
endOffset: number;
@@ -8076,7 +8081,7 @@ interface Document extends Node, DocumentOrShadowRoot, FontFaceSource, GlobalEve
80768081
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/requestStorageAccess) */
80778082
requestStorageAccess(): Promise<void>;
80788083
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/startViewTransition) */
8079-
startViewTransition(callbackOptions?: ViewTransitionUpdateCallback): ViewTransition;
8084+
startViewTransition(callbackOptions?: ViewTransitionUpdateCallback | StartViewTransitionOptions): ViewTransition;
80808085
/**
80818086
* Writes one or more HTML expressions to a document in the specified window.
80828087
* @param content Specifies the text and HTML tags to write.

baselines/ts5.5/dom.generated.d.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -2090,6 +2090,11 @@ interface SpeechSynthesisEventInit extends EventInit {
20902090
utterance: SpeechSynthesisUtterance;
20912091
}
20922092

2093+
interface StartViewTransitionOptions {
2094+
types?: string[] | null;
2095+
update?: ViewTransitionUpdateCallback | null;
2096+
}
2097+
20932098
interface StaticRangeInit {
20942099
endContainer: Node;
20952100
endOffset: number;
@@ -8069,7 +8074,7 @@ interface Document extends Node, DocumentOrShadowRoot, FontFaceSource, GlobalEve
80698074
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/requestStorageAccess) */
80708075
requestStorageAccess(): Promise<void>;
80718076
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/startViewTransition) */
8072-
startViewTransition(callbackOptions?: ViewTransitionUpdateCallback): ViewTransition;
8077+
startViewTransition(callbackOptions?: ViewTransitionUpdateCallback | StartViewTransitionOptions): ViewTransition;
80738078
/**
80748079
* Writes one or more HTML expressions to a document in the specified window.
80758080
* @param content Specifies the text and HTML tags to write.

inputfiles/overridingTypes.jsonc

-13
Original file line numberDiff line numberDiff line change
@@ -817,19 +817,6 @@
817817
"overrideType": "NodeListOf<HTMLElement>"
818818
}
819819
}
820-
},
821-
"startViewTransition": {
822-
"signature": {
823-
"0": {
824-
"param": [
825-
// StartViewTransitionOptions is not implemented as of 2024-06
826-
{
827-
"name": "callbackOptions",
828-
"type": "ViewTransitionUpdateCallback"
829-
}
830-
],
831-
}
832-
}
833820
}
834821
}
835822
},

0 commit comments

Comments
 (0)