Skip to content

Commit 68f8f22

Browse files
authored
Merge pull request microsoft#38425 from dsherret/fixJSDocTagFactoryFuncReturnTypes
Fix some JSDoc factory function return types
2 parents c526b42 + 84f89f8 commit 68f8f22

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

src/compiler/factoryPublic.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -2610,23 +2610,23 @@ namespace ts {
26102610
}
26112611

26122612
export function createJSDocAuthorTag(comment?: string) {
2613-
return createJSDocTag(SyntaxKind.JSDocAuthorTag, "author", comment);
2613+
return createJSDocTag<JSDocAuthorTag>(SyntaxKind.JSDocAuthorTag, "author", comment);
26142614
}
26152615

26162616
export function createJSDocPublicTag() {
2617-
return createJSDocTag(SyntaxKind.JSDocPublicTag, "public");
2617+
return createJSDocTag<JSDocPublicTag>(SyntaxKind.JSDocPublicTag, "public");
26182618
}
26192619

26202620
export function createJSDocPrivateTag() {
2621-
return createJSDocTag(SyntaxKind.JSDocPrivateTag, "private");
2621+
return createJSDocTag<JSDocPrivateTag>(SyntaxKind.JSDocPrivateTag, "private");
26222622
}
26232623

26242624
export function createJSDocProtectedTag() {
2625-
return createJSDocTag(SyntaxKind.JSDocProtectedTag, "protected");
2625+
return createJSDocTag<JSDocProtectedTag>(SyntaxKind.JSDocProtectedTag, "protected");
26262626
}
26272627

26282628
export function createJSDocReadonlyTag() {
2629-
return createJSDocTag(SyntaxKind.JSDocReadonlyTag, "readonly");
2629+
return createJSDocTag<JSDocReadonlyTag>(SyntaxKind.JSDocReadonlyTag, "readonly");
26302630
}
26312631

26322632
export function appendJSDocToContainer(node: JSDocContainer, jsdoc: JSDoc) {

tests/baselines/reference/api/tsserverlibrary.d.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -4272,11 +4272,11 @@ declare namespace ts {
42724272
function createJSDocParameterTag(typeExpression: JSDocTypeExpression | undefined, name: EntityName, isNameFirst: boolean, isBracketed: boolean, comment?: string): JSDocParameterTag;
42734273
function createJSDocTypeLiteral(jsDocPropertyTags?: readonly JSDocPropertyLikeTag[], isArrayType?: boolean): JSDocTypeLiteral;
42744274
function createJSDocImplementsTag(classExpression: JSDocImplementsTag["class"], comment?: string): JSDocImplementsTag;
4275-
function createJSDocAuthorTag(comment?: string): JSDocTag;
4276-
function createJSDocPublicTag(): JSDocTag;
4277-
function createJSDocPrivateTag(): JSDocTag;
4278-
function createJSDocProtectedTag(): JSDocTag;
4279-
function createJSDocReadonlyTag(): JSDocTag;
4275+
function createJSDocAuthorTag(comment?: string): JSDocAuthorTag;
4276+
function createJSDocPublicTag(): JSDocPublicTag;
4277+
function createJSDocPrivateTag(): JSDocPrivateTag;
4278+
function createJSDocProtectedTag(): JSDocProtectedTag;
4279+
function createJSDocReadonlyTag(): JSDocReadonlyTag;
42804280
function appendJSDocToContainer(node: JSDocContainer, jsdoc: JSDoc): JSDocContainer;
42814281
function createJsxElement(openingElement: JsxOpeningElement, children: readonly JsxChild[], closingElement: JsxClosingElement): JsxElement;
42824282
function updateJsxElement(node: JsxElement, openingElement: JsxOpeningElement, children: readonly JsxChild[], closingElement: JsxClosingElement): JsxElement;

tests/baselines/reference/api/typescript.d.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -4272,11 +4272,11 @@ declare namespace ts {
42724272
function createJSDocParameterTag(typeExpression: JSDocTypeExpression | undefined, name: EntityName, isNameFirst: boolean, isBracketed: boolean, comment?: string): JSDocParameterTag;
42734273
function createJSDocTypeLiteral(jsDocPropertyTags?: readonly JSDocPropertyLikeTag[], isArrayType?: boolean): JSDocTypeLiteral;
42744274
function createJSDocImplementsTag(classExpression: JSDocImplementsTag["class"], comment?: string): JSDocImplementsTag;
4275-
function createJSDocAuthorTag(comment?: string): JSDocTag;
4276-
function createJSDocPublicTag(): JSDocTag;
4277-
function createJSDocPrivateTag(): JSDocTag;
4278-
function createJSDocProtectedTag(): JSDocTag;
4279-
function createJSDocReadonlyTag(): JSDocTag;
4275+
function createJSDocAuthorTag(comment?: string): JSDocAuthorTag;
4276+
function createJSDocPublicTag(): JSDocPublicTag;
4277+
function createJSDocPrivateTag(): JSDocPrivateTag;
4278+
function createJSDocProtectedTag(): JSDocProtectedTag;
4279+
function createJSDocReadonlyTag(): JSDocReadonlyTag;
42804280
function appendJSDocToContainer(node: JSDocContainer, jsdoc: JSDoc): JSDocContainer;
42814281
function createJsxElement(openingElement: JsxOpeningElement, children: readonly JsxChild[], closingElement: JsxClosingElement): JsxElement;
42824282
function updateJsxElement(node: JsxElement, openingElement: JsxOpeningElement, children: readonly JsxChild[], closingElement: JsxClosingElement): JsxElement;

0 commit comments

Comments
 (0)