-
Notifications
You must be signed in to change notification settings - Fork 99
Missing ESLint rule disable in @typescript-eslint rule converter(s) #1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
area: incorrect converter
Rule converter with incomplete, incorrect, or invalid rule names and/or arguments
good first issue
Good for newcomers; welcome aboard!
status: accepting prs
Please, send in a PR to resolve this! ✨
Comments
These are the rules
|
A more authorative list can be found here https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/README.md#extension-rules. |
Didn't know there was a list for these rules, glad you shared it 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: incorrect converter
Rule converter with incomplete, incorrect, or invalid rule names and/or arguments
good first issue
Good for newcomers; welcome aboard!
status: accepting prs
Please, send in a PR to resolve this! ✨
🐛 Bug Report
tslint-to-eslint-config
version: 2.4.2Actual Behavior
This issue was created according to this comment: #1085 (comment).
There are @typescript-eslint/... rules that require to turn off their
ESLint
counterpart like this:Source: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-use-before-define.md
In the rule convertNoUseBeforeDeclare this is not disabled.
Also I think it would be good to check all
@typescript-eslint
rule converters for this type of bug.Expected Behavior
@typescript-eslint
rule converters that require to turn off theirESLint
rule counterpart actually turn them off.The text was updated successfully, but these errors were encountered: