fix(eslint-plugin): [no-deprecated] support computed member access

Author: azat-io

packages/eslint-plugin/src/rules/no-deprecated.ts

@@ -394,13 +394,64 @@ export default createRule<Options, MessageIds>({
       });
     }
 
+    function checkMemberExpression(node: TSESTree.MemberExpression): void {
+      if (!node.computed) {
+        return;
+      }
+
+      const propertyType = services.getTypeAtLocation(node.property);
+
+      if (propertyType.isStringLiteral() || propertyType.isLiteral()) {
+        const objectType = services.getTypeAtLocation(node.object);
+
+        let propertyName: string | undefined;
+
+        if (propertyType.isStringLiteral()) {
+          propertyName = propertyType.value;
+        } else if (typeof propertyType.value === 'string') {
+          propertyName = propertyType.value;
+        } else if (typeof propertyType.value === 'number') {
+          propertyName = String(propertyType.value);
+        }
+
+        if (!propertyName) {
+          return;
+        }
+
+        const property = objectType.getProperty(propertyName);
+
+        const reason = getJsDocDeprecation(property);
+        if (reason == null) {
+          return;
+        }
+
+        if (typeMatchesSomeSpecifier(objectType, allow, services.program)) {
+          return;
+        }
+
+        context.report({
+          ...(reason
+            ? {
+                messageId: 'deprecatedWithReason',
+                data: { name: propertyName, reason },
+              }
+            : {
+                messageId: 'deprecated',
+                data: { name: propertyName },
+              }),
+          node: node.property,
+        });
+      }
+    }
+
     return {
       Identifier: checkIdentifier,
       JSXIdentifier(node): void {
         if (node.parent.type !== AST_NODE_TYPES.JSXClosingElement) {
           checkIdentifier(node);
         }
       },
+      MemberExpression: checkMemberExpression,
       PrivateIdentifier: checkIdentifier,
       Super: checkIdentifier,
     };

packages/eslint-plugin/tests/rules/no-deprecated.test.ts

@@ -2893,5 +2893,65 @@ class B extends A {
         },
       ],
     },
+    {
+      code: `
+        const a = {
+          /** @deprecated */
+          b: 'string',
+        };
+
+        const c = a['b'];
+      `,
+      errors: [
+        {
+          column: 21,
+          data: { name: 'b' },
+          endColumn: 24,
+          endLine: 7,
+          line: 7,
+          messageId: 'deprecated',
+        },
+      ],
+    },
+    {
+      code: `
+        const a = {
+          /** @deprecated */
+          b: 'string',
+        };
+        const x = 'b';
+        const c = a[x];
+      `,
+      errors: [
+        {
+          column: 21,
+          data: { name: 'b' },
+          endColumn: 22,
+          endLine: 7,
+          line: 7,
+          messageId: 'deprecated',
+        },
+      ],
+    },
+    {
+      code: `
+        const a = {
+          /** @deprecated */
+          [2]: 'string',
+        };
+        const x = 'b';
+        const c = a[2];
+      `,
+      errors: [
+        {
+          column: 21,
+          data: { name: '2' },
+          endColumn: 22,
+          endLine: 7,
+          line: 7,
+          messageId: 'deprecated',
+        },
+      ],
+    },
   ],
 });