Upgrade coding standards

Author: tangrufus

composer.json

@@ -34,7 +34,7 @@
     "require-dev": {
         "10up/wp_mock": "^0.4.2",
         "codeception/base": "^3.1",
-        "itinerisltd/itineris-wp-coding-standards": "^0.2.3",
+        "itinerisltd/itineris-wp-coding-standards": "^0.3.0",
         "roave/security-advisories": "dev-master"
     },
     "suggest": {

composer.lock

@@ -4,23 +4,44 @@
     <exclude-pattern>/tests/*</exclude-pattern>
     <exclude-pattern>/vendor/*</exclude-pattern>
 
-    <arg value="s"/>
-    <config name="installed_paths" value="vendor/wp-coding-standards/wpcs,vendor/automattic/vipwpcs,vendor/itinerisltd/itineris-wp-coding-standards"/>
-    <config name="minimum_supported_wp_version" value="4.9"/>
+    <!-- Show colors in console -->
+    <arg value="-colors"/>
+
+    <!-- Show progress and sniff codes in all reports; Show progress of the run -->
+    <arg value="sp"/>
+
+    <!-- Scan only PHP files -->
+    <arg name="extensions" value="php"/>
+
+    <!-- Install custom rulesets -->
+    <config name="installed_paths" value="vendor/wp-coding-standards/wpcs,vendor/itinerisltd/itineris-wp-coding-standards"/>
+
+    <config name="minimum_supported_wp_version" value="5.2"/>
+
+    <rule ref="Itineris"/>
 
     <rule ref="WordPress.WP.I18n">
         <properties>
             <property name="text_domain" type="array" value="image-optimize-command"/>
         </properties>
     </rule>
 
-    <!-- Use Itineris WP Coding Standards -->
-    <rule ref="Itineris"/>
-
     <rule ref="Squiz.Commenting.FunctionComment.MissingParamTag">
         <exclude-pattern>/src/*Command.php</exclude-pattern>
     </rule>
 
+    <rule ref="WordPress.NamingConventions.ValidVariableName.PropertyNotSnakeCase">
+        <exclude-pattern>/src/*.php</exclude-pattern>
+    </rule>
+
+    <rule ref="WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase">
+        <exclude-pattern>/src/*.php</exclude-pattern>
+    </rule>
+
+    <rule ref="WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase">
+        <exclude-pattern>/src/*.php</exclude-pattern>
+    </rule>
+
     <rule ref="WordPress.WhiteSpace.ControlStructureSpacing">
         <!--This is because this rule gives internal error Undefined index: parenthesis_owner-->
         <exclude-pattern>/src/Repositories/AttachmentRepository.php</exclude-pattern>

phpcs.xml

@@ -27,15 +27,15 @@ public function takeNonOptimized(int $num): array
                 'post_status' => 'any',
                 'fields' => 'ids',
                 'posts_per_page' => $num,
-                'meta_query' =>
+                'meta_query' => // phpcs:ignore WordPress.DB.SlowDBQuery.slow_db_query_meta_query
                     [
                         [
                             'key' => static::OPTIMIZED_META_KEY,
                             'compare' => 'NOT EXISTS',
                         ],
                     ],
             ]
-        ); // WPCS: slow query ok.
+        );
 
         return $query->posts;
     }
@@ -56,15 +56,15 @@ public function takeOptimized(int $num): array
                 'post_status' => 'any',
                 'fields' => 'ids',
                 'posts_per_page' => $num,
-                'meta_query' =>
+                'meta_query' => // phpcs:ignore WordPress.DB.SlowDBQuery.slow_db_query_meta_query
                     [
                         [
                             'key' => static::OPTIMIZED_META_KEY,
                             'compare' => 'EXISTS',
                         ],
                     ],
             ]
-        ); // WPCS: slow query ok.
+        );
 
         return $query->posts;
     }
@@ -108,12 +108,13 @@ public function markAllAsUnoptimized(): void
     {
         global $wpdb;
 
+        // phpcs:ignore WordPress.DB.DirectDatabaseQuery
         $wpdb->query(
             $wpdb->prepare(
                 "DELETE FROM $wpdb->postmeta WHERE meta_key = %s;",
                 static::OPTIMIZED_META_KEY
             )
-        ); // WPCS: cache ok, db call ok.
+        );
     }
 
     /**