use --disable-http-cache to avoid exporting an old resource.

close dev tools by default to avoid console errors related to it starting up too soon.

Author: ericpyle

app/main.dev.js

@@ -31,6 +31,11 @@ export default class AppUpdater {
 
 let mainWindow = null;
 
+// Disable caching resources to avoid unexpected behavior when exporting metadata.xml and resources
+// see https://github.com/electron/electron/issues/1720
+// and https://github.com/scramjs/scram-engine/issues/5#issuecomment-222323820
+app.commandLine.appendSwitch('--disable-http-cache');
+
 logHelpers.setupLogFile(__dirname, 'debug', 'error');
 log.info('Main App starting...');
 
@@ -68,13 +73,6 @@ app.on('window-all-closed', () => {
 });
 
 app.on('ready', async () => {
-  if (
-    process.env.NODE_ENV === 'development' ||
-    process.env.DEBUG_PROD === 'true'
-  ) {
-    await installExtensions();
-  }
-
   mainWindow = new BrowserWindow({
     show: false,
     width: 1024,
@@ -88,6 +86,20 @@ app.on('ready', async () => {
     `file://${__dirname}/app.html#${navigationConstants.NAVIGATION_WORKSPACES}`
   );
 
+  /*
+     waiting until 'dom-ready' avoids startup errors related to devtools server extension
+     https://github.com/LN-Zap/zap-desktop/pull/500
+  */
+  mainWindow.webContents.on('dom-ready', async () => {
+    mainWindow.webContents.closeDevTools();
+    if (
+      process.env.NODE_ENV === 'development' ||
+      process.env.DEBUG_PROD === 'true'
+    ) {
+      await installExtensions();
+    }
+  });
+
   // @TODO: Use 'ready-to-show' event
   //        https://github.com/electron/electron/blob/master/docs/api/browser-window.md#using-ready-to-show-event
   mainWindow.webContents.on('did-finish-load', () => {
@@ -133,6 +145,7 @@ app.on('ready', async () => {
     mainWindow = null;
   });
 
+  /*
   mainWindow.onerror = err => {
     // log.error(JSON.stringify(err));
   };
@@ -141,7 +154,6 @@ app.on('ready', async () => {
     // log.error(JSON.stringify(err));
   });
 
-  /*
   session.defaultSession.webRequest.onErrorOccurred((details) => {
     log.error(JSON.stringify(details));
   });

app/services/browserWindow.service.js

@@ -191,6 +191,17 @@ function openFileInChromeBrowser(
     show: false,
     ...options
   });
+  browserWin.webContents.on('dom-ready', () => {
+    /*
+    Don't automatically bring up devTools & Reduce spam from a bug:
+    https://github.com/electron/electron/issues/12438#issuecomment-390211011
+    https://github.com/electron/electron/issues/13008
+    [23580:0926/110237.459:ERROR:CONSOLE(24)] "Empty response arrived for script 'chrome-devtools://devtools/remote/serve_file/@67b778eb4e0214a7dd0d01c286f15c0fcb6b3a90/product_registry_impl/product_registry_impl_module.js'",
+source: chrome-devtools://devtools/bundled/shell.js (24)
+[23580:0926/110237.471:ERROR:CONSOLE(108)] "Uncaught (in promise) Error: Could not instantiate: ProductRegistryImpl.Registry", source: chrome-devtools://devtools/bundled/shell.js (108)
+     */
+    browserWin.webContents.closeDevTools();
+  });
   browserWin.loadURL(url);
   browserWin.on('focus', () => {
     buildBrowserMenu(browserWin);

app/services/bundle.service.js

@@ -453,15 +453,10 @@ function requestSaveResourceTo(
   relativeDestinationPath,
   progressCallback = () => {}
 ) {
-  // NOTE: for some reason getting metadata.xml via /resource-stream/ api leads to `Review metadata.xml`
-  // getting the earlier version of the document. So use `/resource/` api instead.
-  // Might be a Chrome feature for responses with attachments
-  // see --disable-http-cache and https://github.com/electron/electron/issues/1720
-  const resourceApi =
-    uriRelativePath === 'metadata.xml'
-      ? RESOURCE_API
-      : `${RESOURCE_API}-stream`;
-  const url = `${dblDotLocalConfigConstants.getHttpDblDotLocalBaseUrl()}/${BUNDLE_API}/${bundleId}/${resourceApi}/${uriRelativePath}`;
+  // NOTE: getting resources via /resource-stream/ api can result in
+  // getting the earlier version of the cached resource.
+  // To avoid this use --disable-http-cache (see https://github.com/electron/electron/issues/1720)
+  const url = `${dblDotLocalConfigConstants.getHttpDblDotLocalBaseUrl()}/${BUNDLE_API}/${bundleId}/${RESOURCE_API}-stream/${uriRelativePath}`;
   const targetPath = path.join(selectedFolder, relativeDestinationPath);
   return download(url, targetPath, progressCallback, authHeader());
 }