### Version 0.48.0 (Capture HTTP ERRORS in logs)

#### Feature

- Capture all HTTP ERRORS in logs

#### Fix

- (Really) Fix Help > Open Error Log... to not duplicate errors
- Catch publication wizard error in Resources dialog to allow app to continue without spinning loading forever.

(Merge branch 'more_http_error_logs')

Author: ericpyle

CHANGELOG.md

@@ -1,3 +1,14 @@
+### Version 0.48.0 (Capture HTTP ERRORS in logs)
+
+#### Feature
+
+- Capture all HTTP ERRORS in logs
+
+#### Fix
+
+- (Really) Fix Help > Open Error Log... to not duplicate errors
+- Catch publication wizard error in Resources dialog to allow app to continue without spinning loading forever.
+
 ### Version 0.47.5 (Fix logs)
 
 #### Fix

app/constants/dblDotLocal.constants.js

@@ -3,6 +3,7 @@ export const dblDotLocalConfig = {
   FLASK_API_DEFAULT: 'http://127.0.0.1:44151',
   DDL_APP_LOG_PREFIX: 'dbl_dot_local_app',
   DDL_APPENDER_ID: 'DDL',
+  HTTP_ERROR_APPENDER_ID: 'HTTP_ERROR',
   DDL_ERROR_LOG_BACKGROUND_COLOR: '#FFBABA',
   DDL_ERROR_LOG_FONT_COLOR: '#CC0000',
   DDL_ERROR_LOG_COUNT_INCREMENT: 'DDL_ERROR_LOG_COUNT_INCREMENT',

app/constants/ipcRenderer.constants.js

@@ -1,6 +1,7 @@
 export const ipcRendererConstants = {
   KEY_IPC_NAVIGATE: 'navigate',
-  KEY_IPC_USER_AUTHENTICATION: 'userAuthentication'
+  KEY_IPC_USER_AUTHENTICATION: 'userAuthentication',
+  KEY_IPC_HTTP_ERROR_DATA: 'HTTP_ERROR_DATA'
 };
 
 export default ipcRendererConstants;

app/helpers/log.helpers.js

@@ -3,6 +3,22 @@ import path from 'path';
 import log4js from 'log4js';
 import { browserWindowService } from '../services/browserWindow.service';
 import dblDotLocalConstants from '../constants/dblDotLocal.constants';
+import { ipcRendererConstants } from '../constants/ipcRenderer.constants';
+
+const { ipcRenderer } = require('electron');
+if (ipcRenderer) {
+  ipcRenderer.on(ipcRendererConstants.KEY_IPC_HTTP_ERROR_DATA, (event, errorDetails) => {
+    const detailsWithMaskedToken = errorDetails.url.startsWith(
+      `${dblDotLocalConstants.FLASK_API_DEFAULT}/events/`
+    )
+      ? {
+          ...errorDetails,
+          url: `${dblDotLocalConstants.FLASK_API_DEFAULT}/events/...`
+        }
+      : errorDetails;
+    log.error(detailsWithMaskedToken, { [dblDotLocalConstants.HTTP_ERROR_APPENDER_ID]: true });
+  });
+}
 
 export const logHelpers = {
   setupLogFile,
@@ -54,6 +70,7 @@ function setupRendererErrorLogs() {
   const errorLogPath = getErrorLogPath();
   const generalAppenderId = 'NAT';
   const ddlAppenderId = dblDotLocalConstants.DDL_APPENDER_ID;
+  const httpErrorAppenderId = dblDotLocalConstants.HTTP_ERROR_APPENDER_ID;
 
   log4js.configure({
     appenders: {
@@ -63,7 +80,8 @@ function setupRendererErrorLogs() {
         maxLogSize: 1048576,
         backups: 3
       },
-      [ddlAppenderId]: { type: 'file', filename: errorLogPath }
+      [ddlAppenderId]: { type: 'file', filename: errorLogPath },
+      [httpErrorAppenderId]: { type: 'file', filename: errorLogPath }
     },
     categories: {
       default: { appenders: [generalAppenderId], level: 'error' }
@@ -72,17 +90,20 @@ function setupRendererErrorLogs() {
 
   const generalErrorLogger = log4js.getLogger(generalAppenderId);
   const ddlErrorLogger = log4js.getLogger(ddlAppenderId);
+  const httpErrorLogger = log4js.getLogger(httpErrorAppenderId);
 
   function errorHook(msg, transport) {
     if (transport !== log.transports.file || msg.level !== 'error') {
       return msg;
     }
     const msgData = msg.data[0];
     const tags = msg.data[1] || {};
-    if (
+    if (tags[httpErrorAppenderId]) {
+      httpErrorLogger.error(msgData);
+    } else if (
+      tags[ddlAppenderId] ||
       (typeof msgData === 'string' &&
-        msgData.startsWith(`${dblDotLocalConstants.DDL_APP_LOG_PREFIX}`)) ||
-      tags[ddlAppenderId]
+        msgData.startsWith(`${dblDotLocalConstants.DDL_APP_LOG_PREFIX}`))
     ) {
       ddlErrorLogger.error(msgData);
     } else {

app/main.dev.js

@@ -17,6 +17,7 @@ import path from 'path';
 import MenuBuilder from './menu';
 import { autoUpdaterServices } from './main-process/autoUpdater.services';
 import { navigationConstants } from './constants/navigation.constants';
+import { ipcRendererConstants } from './constants/ipcRenderer.constants';
 import { logHelpers } from './helpers/log.helpers';
 
 /*
@@ -135,8 +136,60 @@ app.on('ready', async () => {
       // eslint-disable-next-line no-underscore-dangle
       `autoUpdater config path: ${myAutoUpdater._appUpdateConfigPath}`
     );
+    attachDebugger();
   });
 
+  function sendErrorToMainWindow({
+    url,
+    method,
+    status,
+    statusText,
+    mimeType
+  }) {
+    return (err, data) => {
+      // XXX may check data.base64encoded boolean and decode ? Maybe not here...
+      // if (data.base64encoded) ... Buffer.from(data.body, 'base64');
+      const errorDetails = {
+        method,
+        url,
+        status,
+        statusText,
+        mimeType,
+        responseBody: data.body
+      };
+      mainWindow.webContents.send(
+        ipcRendererConstants.KEY_IPC_HTTP_ERROR_DATA,
+        errorDetails
+      );
+    };
+  }
+
+  /* Adapted from https://discuss.atom.io/t/electron-intercept-http-request-response-on-browserwindow/21868/7 */
+  function attachDebugger() {
+    const debug = mainWindow.webContents.debugger;
+    debug.attach('1.1');
+    debug.on('message', (event, method, params) => {
+      if (
+        method === 'Network.responseReceived' &&
+        params.response.status !== 200
+      ) {
+        const { url, status, statusText, mimeType } = params.response;
+        debug.sendCommand(
+          'Network.getResponseBody',
+          { requestId: params.requestId },
+          sendErrorToMainWindow({
+            url,
+            status,
+            statusText,
+            mimeType,
+            method: params.response.requestHeadersText.split(' ')[0]
+          })
+        );
+      }
+    });
+    debug.sendCommand('Network.enable');
+  }
+
   mainWindow.on('focus', () => {
     const menuBuilder = new MenuBuilder(mainWindow);
     menuBuilder.buildMainMenu();
@@ -153,10 +206,6 @@ app.on('ready', async () => {
   process.on('uncaughtException', err => {
     // log.error(JSON.stringify(err));
   });
-
-  session.defaultSession.webRequest.onErrorOccurred((details) => {
-    log.error(JSON.stringify(details));
-  });
    */
   /*
   // Remove this if your app does not use auto updates

app/services/dbl_dot_local.service.js

@@ -476,7 +476,7 @@ function startEventSource(authToken, getState) {
   const eventSource = new EventSource(
     `${dblDotLocalConstants.getHttpDblDotLocalBaseUrl()}/events/${authToken}`
   );
-  log.info(`SSE connected: ${authToken}`);
+  log.info(`SSE connected: ${authToken.substring(0, 16)}...`);
   eventSource.onmessage = event => {
     log.info(event);
   };

package.json

@@ -1,7 +1,7 @@
 {
   "name": "nathanael",
   "productName": "nathanael",
-  "version": "0.47.4",
+  "version": "0.48.0",
   "description": "Electron frontend to DBL dot Local",
   "scripts": {
     "build": "concurrently \"yarn build-main\" \"yarn build-renderer\"",