### Version 0.46.0 (Context Menu for Browser)

#### Feature

- Add Copy menu item to context-menu in extra browser windows (e.g. logs, metadata, reports, etc...)
- Catch more DDL errors

#### Fix

- Upgrade dbl_dot_local_app cleaner_cli (9/24/2019)

(Merge branch 'catch-more-ddl-errors')

Author: ericpyle

CHANGELOG.md

@@ -1,3 +1,14 @@
+### Version 0.46.0 (Context Menu for Browser)
+
+#### Feature
+
+- Add Copy menu item to context-menu in extra browser windows (e.g. logs, metadata, reports, etc...)
+- Catch more DDL errors
+
+#### Fix
+
+- Upgrade dbl_dot_local_app cleaner_cli (9/24/2019)
+
 ### Version 0.45.1 (Error log)
 
 #### Fix

app/actions/alert.actions.js

@@ -1,3 +1,4 @@
+import log from 'electron-log';
 import { alertConstants } from '../constants';
 
 export const alertActions = {
@@ -13,7 +14,12 @@ function success(message) {
 }
 
 function error(data) {
-  return { type: alertConstants.ERROR, error: data.error, message: data.message };
+  log.error(data);
+  return {
+    type: alertConstants.ERROR,
+    error: data.error,
+    message: data.message
+  };
 }
 
 function clear() {

app/actions/bundle.actions.js

@@ -303,6 +303,7 @@ export function setupBundlesEventSource() {
     }
     const listeners = {
       error: e => dispatch(listenError(e)),
+      'storer/tick_exception': e => dispatch(listenError(e)),
       'storer/execute_task': listenStorerExecuteTaskDownloadResources,
       'storer/change_mode': e => dispatch(listenStorerChangeMode(e)),
       'uploader/job': e => dispatch(listenUploaderJob(e)),

app/actions/dblDotLocalConfig.actions.js

@@ -1,5 +1,5 @@
 import log from 'electron-log';
-import { dblDotLocalConfig } from '../constants/dblDotLocal.constants';
+import dblDotLocalConstants from '../constants/dblDotLocal.constants';
 import { dblDotLocalService } from '../services/dbl_dot_local.service';
 import { history } from '../store/configureStore';
 import { navigationConstants } from '../constants/navigation.constants';
@@ -30,21 +30,21 @@ export function loadHtmlBaseUrl() {
     }
   };
   function requestBaseUrl() {
-    return { type: dblDotLocalConfig.HTML_BASE_URL_REQUEST };
+    return { type: dblDotLocalConstants.HTML_BASE_URL_REQUEST };
   }
   function success(dblBaseUrl) {
-    return { type: dblDotLocalConfig.HTML_BASE_URL_RESPONSE, dblBaseUrl };
+    return { type: dblDotLocalConstants.HTML_BASE_URL_RESPONSE, dblBaseUrl };
   }
   function failure(error) {
-    return { type: dblDotLocalConfig.CONFIG_REQUEST_FAILURE, error };
+    return { type: dblDotLocalConstants.CONFIG_REQUEST_FAILURE, error };
   }
 }
 
 export function getDblDotLocalExecStatus() {
   return async dispatch => {
     const { isRunning } = await dblDotLocalService.getDblDotLocalExecStatus();
     return dispatch({
-      type: dblDotLocalConfig.DBL_DOT_LOCAL_PROCESS_STATUS,
+      type: dblDotLocalConstants.DBL_DOT_LOCAL_PROCESS_STATUS,
       isRunning
     });
   };
@@ -64,18 +64,22 @@ export function gotoWorkspaceLoginPage(workspace) {
         configXmlFile
       );
       dblDotLocalExecProcess.stderr.on('data', data => {
-        // log.error(data);
-        const [, errorMessage] = `${data}`.split(
+        const dataString = `${data}`;
+        const [, errorMessage] = dataString.split(
           'dbl_dot_local.dbl_app.DblAppException:'
         );
         if (errorMessage) {
           dispatch(alertActions.error({ message: errorMessage }));
+        } else if (dataString.includes('File "')) {
+          log.error(dataString, {
+            [dblDotLocalConstants.DDL_APPENDER_ID]: true
+          });
         }
       });
       ['error', 'close', 'exit'].forEach(event => {
         dblDotLocalExecProcess.on(event, dblDotLocalExecProcessCode => {
           dispatch({
-            type: dblDotLocalConfig.STOP_WORKSPACE_PROCESS_DONE,
+            type: dblDotLocalConstants.STOP_WORKSPACE_PROCESS_DONE,
             dblDotLocalExecProcess,
             dblDotLocalExecProcessCode
           });
@@ -104,7 +108,7 @@ export function gotoWorkspaceLoginPage(workspace) {
     dblDotLocalExecProcess
   ) {
     return {
-      type: dblDotLocalConfig.START_WORKSPACE_PROCESS,
+      type: dblDotLocalConstants.START_WORKSPACE_PROCESS,
       fullPath,
       configXmlFile,
       dblDotLocalExecProcess
@@ -113,9 +117,9 @@ export function gotoWorkspaceLoginPage(workspace) {
 }
 
 export function incrementErrorLogCount() {
-  return { type: dblDotLocalConfig.DDL_ERROR_LOG_COUNT_INCREMENT };
+  return { type: dblDotLocalConstants.DDL_ERROR_LOG_COUNT_INCREMENT };
 }
 
 export function resetErrorLogCount() {
-  return { type: dblDotLocalConfig.DDL_ERROR_LOG_COUNT_RESET };
+  return { type: dblDotLocalConstants.DDL_ERROR_LOG_COUNT_RESET };
 }

app/components/DblDotLocalAppBar.js

@@ -122,7 +122,7 @@ class DblDotLocalAppBar extends React.PureComponent {
 
   errorHook = (msg, transport) => {
     if (transport !== log.transports.file || msg.level !== 'error') {
-      return msg;
+      return false;
     }
     // just increment error count
     const { incrementAppErrorCount } = this.props;

app/services/browserWindow.service.js

@@ -139,5 +139,9 @@ function openFileInChromeBrowser(
       }
     });
   }
+
+  browserWin.webContents.on('context-menu', () => {
+    Menu.buildFromTemplate([{ role: 'copy' }]).popup(browserWin);
+  });
   return browserWin;
 }

package.json

@@ -1,7 +1,7 @@
 {
   "name": "nathanael",
   "productName": "nathanael",
-  "version": "0.45.1",
+  "version": "0.46.0",
   "description": "Electron frontend to DBL dot Local",
   "scripts": {
     "build": "concurrently \"yarn build-main\" \"yarn build-renderer\"",