Move depends def and add test

Author: LyzardKing

tests/small/test_frameworks_loader.py

@@ -318,6 +318,22 @@ def test_parse_no_framework_run_default_for_category(self):
             self.assertTrue(setup_call.called)
             self.assertEqual(setup_call.call_args, call(install_path=None, auto_accept_license=False))
 
+    def test_parse_category_and_framework_list_dependencies(self):
+        """Parsing category will run default framework"""
+        args = Mock()
+        args.category = "category-a"
+        args.destdir = None
+        args.framework = "framework-b"
+        args.depends = True
+        args.accept_license = False
+        args.remove = False
+        with patch.object(self.CategoryHandler.categories[args.category].frameworks["framework-a"], "depends")\
+                as depends_call:
+            self.CategoryHandler.categories[args.category].run_for(args)
+            self.assertTrue(depends_call.called)
+            remove_call.assert_called_with()
+            # self.assertEqual(setup_call.call_args, call(install_path=None, auto_accept_license=False))
+
     def test_parse_category_and_framework_run_correct_remove_framework(self):
         """Parsing category and framework with --remove run remove on right category and framework"""
         args = Mock()

umake/__init__.py

@@ -132,6 +132,7 @@ def main():
     parser.add_argument("-v", "--verbose", action="count", default=0, help=_("Increase output verbosity (2 levels)"))
 
     parser.add_argument('-r', '--remove', action="store_true", help=_("Remove specified framework if installed"))
+    parser.add_argument('-d', '--depends', action="store_true", help=_("List specified framework dependencies"))
 
     list_group = parser.add_argument_group("List frameworks").add_mutually_exclusive_group()
     list_group.add_argument('-l', '--list', action="store_true", help=_("List all frameworks"))

umake/frameworks/__init__.py

@@ -34,6 +34,7 @@
 from umake.settings import DEFAULT_INSTALL_TOOLS_PATH, UMAKE_FRAMEWORKS_ENVIRON_VARIABLE, DEFAULT_BINARY_LINK_PATH
 from umake.tools import ConfigHandler, NoneDict, classproperty, get_current_arch, get_current_distro_version,\
     is_completion_mode, switch_to_current_user, MainLoop, get_user_frameworks_path, get_current_distro_id
+from umake.interactions import DisplayMessage
 from umake.ui import UI
 
 
@@ -263,6 +264,13 @@ def setup(self):
         # be a normal, kind user as we don't want normal files to be written as root
         switch_to_current_user()
 
+    @abc.abstractmethod
+    def depends(self):
+        """Method call to list depends for current framework"""
+        if not self.is_installable:
+            logger.error(_("Framework {} is not installable".format(self.name)))
+            UI.return_main_screen(status_code=2)
+
     @abc.abstractmethod
     def remove(self):
         """Method call to remove the current framework"""
@@ -300,6 +308,8 @@ def install_framework_parser(self, parser):
                                                                         "destdir should contain a /"))
         this_framework_parser.add_argument('-r', '--remove', action="store_true",
                                            help=_("Remove framework if installed"))
+        this_framework_parser.add_argument('-d', '--depends', action="store_true",
+                                           help=_("List dependencies"))
         if self.expect_license:
             this_framework_parser.add_argument('--accept-license', dest="accept_license", action="store_true",
                                                help=_("Accept license without prompting"))
@@ -314,6 +324,12 @@ def run_for(self, args):
                 logger.error(message)
                 UI.return_main_screen(status_code=2)
             self.remove()
+        if args.depends:
+            if args.destdir:
+                message = "You can't specify a destination dir while listing framework dependencies"
+                logger.error(message)
+                UI.return_main_screen(status_code=2)
+            self.depends()
         else:
             install_path = None
             auto_accept_license = False

umake/frameworks/baseinstaller.py

@@ -119,6 +119,15 @@ def reinstall(self):
         self.confirm_path(self.arg_install_path)
         remove_framework_envs_from_user(self.name)
 
+    def depends(self):
+        """List necessary apt dependencies"""
+        if not self.need_root_access:
+            UI.display(DisplayMessage("Required packages are installed"))
+        else:
+            UI.display(DisplayMessage("Required packages will be installed"))
+        UI.display(DisplayMessage(' '.join(self.packages_requirements)))
+        UI.return_main_screen(status_code=0)
+
     def remove(self):
         """Remove current framework if installed