Skip to content

Commit 70ae98e

Browse files
committed
fix xbar policy due to visiblity-filtered input
1 parent 134b1e4 commit 70ae98e

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

src/main/scala/gemmini/Controller.scala

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class Gemmini[T <: Data : Arithmetic, U <: Data, V <: Data](val config: GemminiA
6565
TLMasterPortParameters.v1(Seq(TLMasterParameters.v1(
6666
name = s"spad_read_node_$i",
6767
sourceId = IdRange(0, num_ids),
68-
visibility = Seq(AddressSet(spad_base + i * mem_width * mem_depth, mem_width * mem_depth - 1)),
68+
// visibility = Seq(AddressSet(spad_base + i * mem_width * mem_depth, mem_width * mem_depth - 1)),
6969
supportsProbe = TransferSizes(mem_width, mem_width),
7070
supportsGet = TransferSizes(mem_width, mem_width)
7171
)))
@@ -75,7 +75,7 @@ class Gemmini[T <: Data : Arithmetic, U <: Data, V <: Data](val config: GemminiA
7575
TLMasterPortParameters.v1(Seq(TLMasterParameters.v1(
7676
name = s"spad_write_node_$i",
7777
sourceId = IdRange(0, num_ids),
78-
visibility = Seq(AddressSet(spad_base + i * mem_width * mem_depth, mem_width * mem_depth - 1)),
78+
// visibility = Seq(AddressSet(spad_base + i * mem_width * mem_depth, mem_width * mem_depth - 1)),
7979
supportsProbe = TransferSizes(mem_width, mem_width),
8080
supportsPutFull = TransferSizes(mem_width, mem_width),
8181
supportsPutPartial = TransferSizes(mem_width, mem_width)
@@ -208,9 +208,10 @@ class GemminiModule[T <: Data: Arithmetic, U <: Data, V <: Data]
208208
val mx_io = Option.when(outer.config.use_mx_scaling && outer.config.requantizer.isDefined && outer.config.lut.isDefined) {
209209
val q = outer.config.requantizer.get
210210
val l = outer.config.lut.get
211+
val s = outer.config.scale_mem.get
211212
val mx_io = IO(new Bundle {
212-
val scale_mem_write_w = Flipped(Decoupled(spad.module.io.scale_mem_write_w.get.bits.cloneType))
213-
val scale_mem_write_act = Flipped(Decoupled(spad.module.io.scale_mem_write_act.get.bits.cloneType))
213+
val scale_mem_write_w = Flipped(Decoupled(new ScalingFactorWriteReq(s)))
214+
val scale_mem_write_act = Flipped(Decoupled(new ScalingFactorWriteReq(s)))
214215
val requant_in_gpu = Flipped(Decoupled(new RequantizerInBundle(q.numGPUInputLanes, q.inputBits)))
215216
val requant_out = Decoupled(new RequantizerOutBundle(q.numOutputLanes, q.maxOutputBits))
216217
val lut0 = Flipped(Decoupled(new QuantLutWriteBundle(l)))

src/main/scala/gemmini/MxConfigFragments.scala

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,3 @@ class QuantLutWriteBundle(numEntries: Int, numBits: Int) extends Bundle {
8383
this(config.numEntries, config.numBits)
8484
}
8585
}
86-
87-
class QuantLutReadReq(raddrWidth: Int) extends Bundle {
88-
val lutaddr = UInt(raddrWidth.W)
89-
}
90-
91-
class QuantLutReadResp(rdataWidth: Int) extends Bundle {
92-
val lutdata = UInt(rdataWidth.W)
93-
}

0 commit comments

Comments
 (0)